Page MenuHomePhabricator

Toggling a Reading List article should be streamlined for removal
Closed, ResolvedPublic2 Estimated Story Points

Description

Steps to reproduce

  1. Open an article
  2. Tap to add it to a reading list via the bookmark icon in the article toolbar
  3. Tap on the icon again

Expected results

User is presented with a way to remove the article from that reading list via the same bookmark icon

Actual results

only addition is possible, removal is not

Proposed update to workflow

For an article that has already been saved to one or more lists, if the bookmark button is tapped, an overflow menu will appear with the following options:

  • Add to another reading list
  • Remove from <name of list it is saved in> (Note: 'Remove' appears as a separate action for every list to which the article belongs)

Mocks showing workflow

  • Redline version of mocks also on Zeplin board: https://zpl.io/Z1UvAFi (tagged with "T142027 - Toggle save article to list")

    Event Timeline

    Proposed workflow steps:

    • Adding a page to a reading list remains the way it is today (tap the bookmark icon).
    • If the page already exists in a reading list, tapping the bookmark button should show a dialog message saying "Do you want to remove this article from your reading lists?" (yes / no)
    • If the user selects Yes, the page is removed from any reading list to which it belongs. (button state adjusts accordingly)
    • This should apply to the bookmark button in the bottom toolbar on the page, as well as the bookmark button in the Featured Article feed card.
    Dbrant removed the point value for this task.Oct 6 2016, 6:10 PM
    Dbrant set the point value for this task to 2.Oct 21 2016, 6:17 PM
    Niedzielski renamed this task from [BUG] Toggling a Reading List article should be streamlined for removal to Toggling a Reading List article should be streamlined for removal.Oct 21 2016, 6:17 PM
    RHo updated the task description. (Show Details)
    Kaartic rescinded a token.
    Kaartic awarded a token.
    Kaartic subscribed.

    Change 342225 had a related patch set uploaded (by Dbrant):
    [apps/android/wikipedia] Improve logic to remove article from reading list in PageActivity.

    https://gerrit.wikimedia.org/r/342225

    Proposal based on our discussion today:
    If an article appears on 1 list, the bookmark icon is shown as filled with the following actions appearing on the overflow menu:

    • Add to reading list
    • Remove from <name of list>

    Else if an article appears on >1 list, the bookmark icon is shown as filled with the following actions appearing on the overflow menu:

    • Add to reading list
    • Remove from reading list
      • Selecting this option will bring up a dialog for the user to select which list to remove the article from:

    pasted_file (344×328 px, 23 KB)

    one little request on this proposed dialog: allow selecting all reading lists at once.

    Change 342225 merged by jenkins-bot:
    [apps/android/wikipedia@master] Improve logic to remove articles from reading lists.

    https://gerrit.wikimedia.org/r/342225

    ABorbaWMF subscribed.

    Tested on Nexus 4 Android 5.1 and Pixel Android 7.1.1 both running 2.5.195-alpha-2017-04-26

    Tested adding and removing articles from single/multiple lists. the behavior appears to be working as desired.