Page MenuHomePhabricator
Create Task
Maniphest T142044

PointerOverlay misbehaves on RTL
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
dr0ptp4kt
Authored By
Jdlrobson
Aug 3 2016, 9:48 PM
Tags
Referenced Files
F4334507: Screen Shot 2016-08-03 at 2.47.13 PM.png
Aug 3 2016, 9:48 PM
F4334509: Screen Shot 2016-08-03 at 2.46.49 PM.png
Aug 3 2016, 9:48 PM
Subscribers
Aklapper
• bmansurov
dr0ptp4kt
gerritbot
Jdlrobson

Description

Upon testing the pointer behaviour on Hebrew Wikipedia I noticed the following issues:

Screen Shot 2016-08-03 at 2.47.13 PM.png (272×401 px, 26 KB)

Screen Shot 2016-08-03 at 2.46.49 PM.png (407×1 px, 102 KB)

Details

SubjectRepoBranchLines +/-
Correctly display PointerOverlay on RTL wikismediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.13+1 -0
Correctly display PointerOverlay on RTL wikismediawiki/extensions/MobileFrontendmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 3 2016, 9:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2016, 9:48 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 3 2016, 9:50 PM
Jdlrobson added a parent task: T138961: Deploy mobile language button placement improvement to a larger-medium wiki on Tuesday week two of sprint.
dr0ptp4kt mentioned this in T138961: Deploy mobile language button placement improvement to a larger-medium wiki on Tuesday week two of sprint.Aug 3 2016, 10:08 PM
dr0ptp4kt triaged this task as High priority.Aug 4 2016, 5:00 PM
dr0ptp4kt removed a project: Reading-Web-Sprint-78-Terminal-Velocity.
dr0ptp4kt subscribed.

Removing the current sprint tag merely for the purpose of putting it on the triage today.

• bmansurov subscribed.Aug 4 2016, 5:08 PM

I'm currently working on T141680 and I think my solution will benefit this patch too.

dr0ptp4kt added projects: Reading-Web-Sprint-78-Terminal-Velocity, Web-Team-Backlog.Aug 4 2016, 5:10 PM
dr0ptp4kt moved this task from Incoming to 2016-17 Q1 on the Web-Team-Backlog board.
• bmansurov claimed this task.Aug 4 2016, 6:09 PM
• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-78-Terminal-Velocity board.
gerritbot subscribed.Aug 4 2016, 6:42 PM

Change 302963 had a related patch set uploaded (by Bmansurov):
Correctly display PointerOverlay on RTL wikis

https://gerrit.wikimedia.org/r/302963

gerritbot added a project: Patch-For-Review.Aug 4 2016, 6:42 PM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 4 2016, 6:43 PM
gerritbot added a comment.Aug 4 2016, 8:08 PM

Change 302963 merged by jenkins-bot:
Correctly display PointerOverlay on RTL wikis

https://gerrit.wikimedia.org/r/302963

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 4 2016, 8:25 PM
gerritbot added a comment.Aug 4 2016, 8:26 PM

Change 302992 had a related patch set uploaded (by Jdlrobson):
Correctly display PointerOverlay on RTL wikis

https://gerrit.wikimedia.org/r/302992

Jdlrobson removed projects: Patch-For-Review, Web-Team-Backlog.Aug 4 2016, 8:28 PM

https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=816358&oldid=816354 is on the deploy calendar for today.

• bmansurov removed • bmansurov as the assignee of this task.Aug 4 2016, 8:34 PM

To test please visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Lang?uselang=he and click on the "לקרוא בשפה אחרת" button.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)).Aug 4 2016, 9:00 PM
gerritbot added a comment.Aug 4 2016, 11:07 PM

Change 302992 merged by jenkins-bot:
Correctly display PointerOverlay on RTL wikis

https://gerrit.wikimedia.org/r/302992

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Aug 5 2016, 12:00 AM
Jdlrobson assigned this task to dr0ptp4kt.Aug 5 2016, 1:24 AM

This was successfully swatted. Adam please sign off.

dr0ptp4kt closed this task as Resolved.Aug 6 2016, 11:50 AM

Signing off.

MBinder_WMF set the point value for this task to 1.Aug 8 2016, 5:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits