Page MenuHomePhabricator
Create Task
Maniphest T142121

Remove UnitTestsList hook subscribers, move tests to be autodiscovered for WMF extensions that have been converted to extension registration
Open, MediumPublic
Actions

Description

Same as T142120: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration, just more specifically for WMF extensions.

Current list as currently in 1.31.0-wmf.10:

Non-Wikimedia-production isage:

  • Extension:BlueSpiceVisualEditorConnector
  • JeroenDeDauw/SubPageList (archived from Phab/gerrit)
  • JeroenDeDauw/Validator (archived from Phab/gerrit)
  • SemanticMediaWiki/SemanticDrilldown (archived from Phab/gerrit)
  • SemanticMediaWiki/SemanticResultFormats (archived from Phab/gerrit)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move test config to registration, drop UnitTestsListmediawiki/extensions/DonationInterfacemaster+5 -19
Move test autoloading to extension registrymediawiki/extensions/DonationInterfacemaster+16 -17
Remove 'UnitTestList' hookmediawiki/extensions/TimedMediaHandlermaster+0 -24
Remove UnitTestsList hook subscribermediawiki/extensions/DonationInterfacemaster+0 -38
Remove 'UnitTestList' hookmediawiki/extensions/CentralNoticemaster+6 -28
Remove UnitTestsList hook subscribermediawiki/extensions/BounceHandlermaster+0 -31
Remove UnitTestsList hook subscribermediawiki/extensions/OAuthmaster+1 -12
Remove UnitTestList hook subscribermediawiki/extensions/CirrusSearchmaster+1 -26
Remove UnitTestsList hook subscribermediawiki/extensions/GettingStartedmaster+1 -13
Remove 'UnitTestList' hookmediawiki/extensions/UserMergemaster+1 -30
Remove 'UnitTestList' hookmediawiki/extensions/VipsScalermaster+0 -16
Remove UnitTestsList hook subscribermediawiki/extensions/UserMergemaster+1 -30
Remove 'UnitTestList' hookmediawiki/extensions/TextExtractsmaster+0 -9
Remove 'UnitTestList' hookmediawiki/extensions/MassMessagemaster+2 -27
Add extension.json, empty PHP entry pointmediawiki/extensions/JsonConfigmaster+205 -166
Remove 'UnitTestList' hookmediawiki/extensions/Gadgetsmaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/ParserFunctionsmaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/WikibaseQualitymaster+1 -18
Remove 'UnitTestList' hookmediawiki/extensions/ProofreadPagemaster+6 -34
Remove 'UnitTestList' hookmediawiki/extensions/Mathmaster+0 -16
Remove 'UnitTestList' hookmediawiki/extensions/GlobalCssJsmaster+2 -23
Remove 'UnitTestList' hookmediawiki/extensions/Babelmaster+0 -8
Remove 'UnitTestList' hookmediawiki/extensions/GuidedTourmaster+0 -15
Remove 'UnitTestList' hookmediawiki/extensions/Capiuntomaster+0 -15
Remove 'UnitTestList' hookmediawiki/extensions/Elasticamaster+0 -42
Remove 'UnitTestList' hookmediawiki/extensions/CommonsMetadatamaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/EventBusmaster+0 -11
Remove 'UnitTestList' hookmediawiki/extensions/ExtensionDistributormaster+0 -30
Remove 'UnitTestList' hookmediawiki/extensions/Kartographermaster+0 -16
Remove 'UnitTestList' hookmediawiki/extensions/ConfirmEditmaster+7 -36
Remove 'UnitTestList' hookmediawiki/extensions/WikimediaIncubatormaster+1 -11
Remove 'UnitTestList' hookmediawiki/extensions/WikimediaEventsmaster+0 -23
Remove 'UnitTestList' hookmediawiki/extensions/TitleBlacklistmaster+0 -14
Remove 'UnitTestList' hookmediawiki/extensions/WikidataPageBannermaster+0 -24
Remove 'UnitTestList' hookmediawiki/extensions/Thanksmaster+0 -18
Remove 'UnitTestList' hookmediawiki/extensions/PageAssessmentsmaster+0 -10
Remove 'UnitTestList' hookmediawiki/extensions/ORESmaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/TemplateDatamaster+0 -12
Remove 'UnitTestList' hookmediawiki/extensions/LocalisationUpdatemaster+0 -21
Remove 'UnitTestList' hookmediawiki/extensions/RelatedArticlesmaster+0 -21
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Aug 5 2016, 5:16 PM

Change 303215 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303215

gerritbot added a comment.Aug 5 2016, 5:17 PM

Change 303216 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303216

gerritbot added a comment.Aug 5 2016, 5:18 PM

Change 303217 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303217

gerritbot added a comment.Aug 5 2016, 5:58 PM

Change 303214 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303214

gerritbot added a comment.Aug 5 2016, 6:14 PM

Change 303205 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303205

gerritbot added a comment.Aug 5 2016, 6:21 PM

Change 303207 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303207

gerritbot added a comment.Aug 5 2016, 6:21 PM

Change 303211 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303211

gerritbot added a comment.Aug 5 2016, 6:21 PM

Change 303212 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303212

gerritbot added a comment.Aug 5 2016, 6:21 PM

Change 303215 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303215

gerritbot added a comment.Aug 5 2016, 6:21 PM

Change 303213 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303213

gerritbot added a comment.Aug 5 2016, 6:21 PM

Change 303216 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303216

gerritbot added a comment.Aug 5 2016, 6:27 PM

Change 303217 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303217

gerritbot added a comment.Aug 5 2016, 6:27 PM

Change 303209 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303209

gerritbot added a comment.Aug 5 2016, 7:06 PM

Change 303249 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303249

gerritbot added a comment.Aug 5 2016, 7:44 PM

Change 303260 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303260

gerritbot added a comment.Aug 5 2016, 7:47 PM

Change 303261 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303261

gerritbot added a comment.Aug 5 2016, 8:07 PM

Change 303200 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303200

gerritbot added a comment.Aug 5 2016, 8:07 PM

Change 303249 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303249

gerritbot added a comment.Aug 5 2016, 8:10 PM

Change 303260 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303260

gerritbot added a comment.Aug 5 2016, 8:25 PM

Change 303268 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303268

gerritbot added a comment.Aug 5 2016, 8:42 PM

Change 303268 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303268

gerritbot added a comment.Aug 6 2016, 12:02 AM

Change 262711 had a related patch set uploaded (by Reedy):
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/262711

gerritbot added a comment.Aug 6 2016, 11:18 PM

Change 303210 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303210

gerritbot added a comment.Aug 10 2016, 6:45 AM

Change 262711 merged by jenkins-bot:
Add extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/262711

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 10 2016, 7:00 AM
gerritbot added a comment.Aug 10 2016, 9:18 PM

Change 304120 had a related patch set uploaded (by Reedy):
Remove UnitTestList hook subscriber

https://gerrit.wikimedia.org/r/304120

gerritbot added a comment.Aug 10 2016, 11:35 PM

Change 304142 had a related patch set uploaded (by Reedy):
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/304142

gerritbot added a comment.Aug 18 2016, 4:38 AM

Change 303201 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303201

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 18 2016, 4:01 PM
gerritbot added a comment.Aug 23 2016, 3:18 PM

Change 303191 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303191

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)).Aug 23 2016, 4:00 PM
gerritbot added a comment.Oct 1 2016, 9:56 AM

Change 313653 had a related patch set uploaded (by Reedy):
Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/313653

gerritbot added a project: Patch-For-Review.Oct 1 2016, 9:56 AM
Reedy updated the task description. (Show Details)Oct 1 2016, 9:58 AM
gerritbot added a comment.Oct 1 2016, 10:01 AM

Change 313654 had a related patch set uploaded (by Reedy):
Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/313654

gerritbot added a comment.Oct 1 2016, 10:02 AM

Change 313655 had a related patch set uploaded (by Reedy):
Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/313655

gerritbot added a comment.Oct 1 2016, 10:04 AM

Change 313656 had a related patch set uploaded (by Reedy):
Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/313656

gerritbot added a comment.Oct 1 2016, 10:05 AM

Change 313655 abandoned by Reedy:
Remove UnitTestsList hook subscriber

Reason:
Duped

https://gerrit.wikimedia.org/r/313655

gerritbot added a comment.Oct 2 2016, 3:48 AM

Change 304142 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/304142

gerritbot added a comment.Oct 2 2016, 3:48 AM

Change 303188 merged by jenkins-bot:
Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303188

gerritbot added a comment.Oct 2 2016, 3:49 AM

Change 313656 merged by jenkins-bot:
Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/313656

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Oct 2 2016, 4:00 AM
gerritbot added a comment.Oct 9 2016, 1:01 AM

Change 304120 abandoned by Reedy:
Remove UnitTestList hook subscriber

Reason:
This will need redoing when it eventually happens

https://gerrit.wikimedia.org/r/304120

Reedy triaged this task as Medium priority.Nov 27 2016, 10:41 PM
Reedy removed projects: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)), MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)).
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:12 AM
SamanthaNguyen updated the task description. (Show Details)Sep 4 2017, 11:13 PM
SamanthaNguyen subscribed.
Aklapper added a comment.Nov 20 2017, 6:40 PM

If someone edited the task description and provided clearer steps what's to do here, could this be Google-Code-in-2017 tasks if someone mentored?

Jdforrester-WMF updated the task description. (Show Details)Nov 28 2017, 12:13 AM
gerritbot added a comment.Nov 28 2017, 12:14 AM

Change 313653 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/313653

Jdforrester-WMF updated the task description. (Show Details)Nov 28 2017, 12:15 AM
Jdforrester-WMF subscribed.
In T142121#3775312, @Aklapper wrote:

If someone edited the task description and provided clearer steps what's to do here, could this be Google-Code-in-2017 tasks if someone mentored?

At this point I don't think it's worth it (just one deployed extension left).

Reedy updated the task description. (Show Details)Nov 28 2017, 12:16 AM
Jdforrester-WMF updated the task description. (Show Details)Nov 28 2017, 12:16 AM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Nov 28 2017, 12:18 AM

Change 313654 merged by jenkins-bot:
[mediawiki/extensions/BounceHandler@master] Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/313654

gerritbot added a comment.Nov 28 2017, 12:51 AM

Change 393697 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/DonationInterface@master] Remove UnitTestsList hook subscriber

https://gerrit.wikimedia.org/r/393697

gerritbot added a project: Patch-For-Review.Nov 28 2017, 12:51 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 28 2017, 1:00 AM
Reedy updated the task description. (Show Details)Nov 28 2017, 1:34 AM
Jdforrester-WMF updated the task description. (Show Details)Jan 19 2018, 6:11 PM

Found some more via https://codesearch.wmflabs.org/extensions/?q=UnitTestsList&i=nope&files=&repos=

Jdforrester-WMF updated the task description. (Show Details)Jan 19 2018, 6:16 PM
gerritbot added a comment.Apr 19 2018, 4:20 PM

Change 303261 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/303261

Jdforrester-WMF updated the task description. (Show Details)Apr 19 2018, 4:24 PM
Jdforrester-WMF removed a parent task: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.
Jdforrester-WMF added a subtask: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.
Umherirrender updated the task description. (Show Details)Apr 20 2018, 7:58 PM
gerritbot added a comment.May 25 2018, 10:07 PM

Change 393697 abandoned by Krinkle:
Remove UnitTestsList hook subscriber

Reason:
Superseded by Ie34bac44d7708161d00c47e16b5c092f9585916f

https://gerrit.wikimedia.org/r/393697

Krinkle updated the task description. (Show Details)May 25 2018, 10:08 PM
Krinkle removed a subtask: T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.Sep 11 2018, 9:37 PM
gerritbot added a comment.May 19 2019, 12:44 PM

Change 511313 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/TimedMediaHandler@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/511313

gerritbot added a comment.May 19 2019, 2:01 PM

Change 511313 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove 'UnitTestList' hook

https://gerrit.wikimedia.org/r/511313

TheDJ updated the task description. (Show Details)May 19 2019, 2:39 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 19 2019, 3:00 PM
Reedy updated the task description. (Show Details)May 21 2019, 3:25 PM
Umherirrender removed a project: Patch-For-Review.Apr 5 2022, 7:15 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 13 2023, 7:03 AM
hashar added a parent task: T298509: Deprecate UnitTestsListHook.Jun 25 2025, 7:59 PM
hashar removed a parent task: T142120: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration.
hashar subscribed.

DonationInterface and Wikibase are the last one still using UnitTestsList.

DonationInterface had https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/428059 which I guess need to be rebased.

For Wikibase, I have no idea given the repository hosts TWO extensions :-/

hashar mentioned this in T142120: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration.Jun 25 2025, 8:08 PM
hashar mentioned this in T298509: Deprecate UnitTestsListHook.
gerritbot added a comment.Jul 8 2025, 2:16 PM

Change #1167228 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/DonationInterface@master] Move test autoloading to extension registry

https://gerrit.wikimedia.org/r/1167228

gerritbot added a project: Patch-For-Review.Jul 8 2025, 2:16 PM
gerritbot added a comment.Jul 8 2025, 2:25 PM

Change #1167230 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/DonationInterface@master] Move test config to registration drop UnitTestsList

https://gerrit.wikimedia.org/r/1167230

hashar updated the task description. (Show Details)Jul 8 2025, 3:00 PM
hashar updated the task description. (Show Details)Jul 8 2025, 3:07 PM
hashar updated the task description. (Show Details)
gerritbot added a comment.Jul 8 2025, 3:19 PM

Change #1167228 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Move test autoloading to extension registry

https://gerrit.wikimedia.org/r/1167228

gerritbot added a comment.Jul 8 2025, 3:20 PM

Change #1167230 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Move test config to registration, drop UnitTestsList

https://gerrit.wikimedia.org/r/1167230

Jdforrester-WMF updated the task description. (Show Details)Jul 8 2025, 3:22 PM
Jdforrester-WMF added a project: BlueSpice.Jul 8 2025, 3:24 PM
Jdforrester-WMF updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Jul 8 2025, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits