DuplicateReferences: insertReference triggers TypeError
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sjoerddebruin
	Aug 5 2016, 1:38 PM

Description

Inserting references using the DuplicateReferences isn't possible at the moment, the JavaScript console gives the following error:

TypeError: undefined is not an object (evaluating 'statementview.options.claimsChanger.setStatement')

Related Objects

Mentioned In: T127055: [Task] Use ViewController for editing in statementview

Event Timeline

Sjoerddebruin created this task.Aug 5 2016, 1:38 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptAug 5 2016, 1:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Sjoerddebruin triaged this task as High priority.Aug 5 2016, 1:38 PM

Lydia_Pintscher added subscribers: • Jonas, thiemowmde.Aug 5 2016, 1:41 PM

The gadget is working again, see here. It is only a temporary solution though. What is needed to fix this properly?

Sjoerddebruin moved this task from Backlog to Bugs on the Wikidata-Gadgets board.Aug 17 2016, 7:47 PM

Deployment has just taken place, gadget is broken again:

TypeError: undefined is not an object (evaluating 'statementview._controller._model')

Sjoerddebruin mentioned this in T127055: [Task] Use ViewController for editing in statementview.Sep 7 2016, 8:03 PM

Right solution for this would be to have a top-level WikibaseRepo factory WikibaseRepo with a method getEntityChangersFactory. The EntityChangersFactory could then be used to get a StatementsChanger.

In T142203#2617033, @adrianheine wrote:

Right solution for this would be to have a top-level WikibaseRepo factory WikibaseRepo with a method getEntityChangersFactory. The EntityChangersFactory could then be used to get a StatementsChanger.

Would you be able to do that or do you know someone who can?

Lydia_Pintscher added a project: Wikidata-Sprint-2016-09-21.Sep 8 2016, 9:57 PM

Josve05a subscribed.Sep 9 2016, 5:44 PM

Thryduulf subscribed.Sep 9 2016, 6:12 PM

Lydia_Pintscher added a project: Wikidata-Sprint-2016-09-06.Sep 14 2016, 1:12 PM

Lydia_Pintscher moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-09-06 board.

Jklamo subscribed.Sep 18 2016, 8:07 PM

• Jonas moved this task from Proposed to Done on the Wikidata-Sprint-2016-09-21 board.Sep 21 2016, 9:23 AM

• Jonas moved this task from Done to Review on the Wikidata-Sprint-2016-09-21 board.

• Jonas moved this task from Review to Done on the Wikidata-Sprint-2016-09-21 board.Sep 21 2016, 9:29 AM

I quick fixed the gadget, but I agree with @adrianheine that we should extract a lot of code from entityViewInit to a factory, making the reuse of code in gadgets possible.

• Jonas moved this task from Done to Doing on the Wikidata-Sprint-2016-09-21 board.Sep 21 2016, 11:45 AM

There seems to be more broken than just the saving

Well, worked fine for me :) but if there are more things to fix, maybe a new ticket...

Well, the basic function is working. No need to reopen this task imo. Could create separate tasks for the things that still need to be done.

Will make separate tasks for the (introduced) issues.

Lydia_Pintscher moved this task from Doing to Done on the Wikidata-Sprint-2016-09-21 board.Sep 26 2016, 5:36 PM

DuplicateReferences: insertReference triggers TypeErrorClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

DuplicateReferences: insertReference triggers TypeError
Closed, ResolvedPublic
Actions