Page MenuHomePhabricator

Notification group has a redundant separator
Closed, ResolvedPublic

Description

It also isn't necessary when the group is expanded

Event Timeline

Esanders created this task.Aug 5 2016, 9:40 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 5 2016, 9:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think this is how it was originally designed. @Pginer-WMF is on vacation for a few more days but should hopefully be able to respond to this once he gets back.

Esanders added a comment.EditedAug 5 2016, 9:47 PM

Expanded:

This one is definitely wrong.

The visual metaphor used for bundles was about notifications being stacked on top of each other. The line is a subtle indicator that these are not a single notification but a stack of many.

When expanded, it seems that the additional line is still visible, and as noted by @Esanders, it should not be the case.

The visual metaphor used for bundles was about notifications being stacked on top of each other. The line is a subtle indicator that these are not a single notification but a stack of many.

I'm not sure that reads. Does it need to be multiple lines or something else?

That line generates a separation which is intended to be consistent with how the notification opens (notice in your example of F4339766 the bottom white element that helps separate what's inside the notification from what is outside, especially when the next one is a read one).

We can explore other options, but I'd keep it in the subtle side since the "expand" label and icon already communicate clearly the functionality.

The visual metaphor used for bundles was about notifications being stacked on top of each other. The line is a subtle indicator that these are not a single notification but a stack of many.

When expanded, it seems that the additional line is still visible, and as noted by @Esanders, it should not be the case.

Sorry, I'm a little confused, which of the lines should not be visible when expanded?

The visual metaphor used for bundles was about notifications being stacked on top of each other. The line is a subtle indicator that these are not a single notification but a stack of many.

When expanded, it seems that the additional line is still visible, and as noted by @Esanders, it should not be the case.

Sorry, I'm a little confused, which of the lines should not be visible when expanded?

It is a light grey line on a lighter grey background, so it may not be easy to notice depending on the contrast settings of your screen. I tried to zoom it below to clarify:

If my DOM inspection is correct, it is the "mw-echo-ui-crossWikiNotificationItemWidget-separator" element which should be visible when the bundle is collapsed but hidden when expanded.

Change 308001 had a related patch set uploaded (by Mooeypoo):
Hide xwiki widget separator when widget is expanded

https://gerrit.wikimedia.org/r/308001

Awesome, thank you!

I added a class for the expanded widget and I'm using that to hide that separator when the widget is expanded in this patch.

Change 308001 merged by jenkins-bot:
Hide xwiki widget separator when widget is expanded

https://gerrit.wikimedia.org/r/308001

Checked in betalabs

  • "mw-echo-ui-crossWikiNotificationItemWidget-separator" is gone


@Pginer-WMF and @Mooeypoo - for bundled notifications the grey additional line should be removed too?

Change 309205 had a related patch set uploaded (by Mooeypoo):
Hide separator when bundled item is expanded

https://gerrit.wikimedia.org/r/309205

Whoops, my bad. Fix on the way.

Change 309205 merged by jenkins-bot:
Hide separator when bundled item is expanded

https://gerrit.wikimedia.org/r/309205

For both bundled cases - cross-wiki and local bundles - the additional grey line is removed.

jmatazzoni closed this task as Resolved.Oct 11 2016, 12:34 AM