Page MenuHomePhabricator

'Pending' blocks don't match the width of the items they are placeholders for during notifications page load
Open, Needs TriagePublic

Description

See video:

https://www.youtube.com/watch?v=tMzpQLtA6Bg

Also the 'pending' sprite was designed to be used as the background for dialog headers, i.e. within a border of a control that has some rendering already - not just something may appear in this general area. You may want to using an indeterminate progress bar instead.

Related Objects

Event Timeline

Esanders created this task.Aug 5 2016, 10:09 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 5 2016, 10:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The initial pending block appears before the JavaScript lodas, so we couldn't really use the progress bar from ooui.

The width issue is a good point, though - the special page widget should load 100% width, so the pending block follows the same principle of reloading the notifications when using the filters or pagination.

Shouldn't you be loading OOUI onto this page synchronously?

Shouldn't you be loading OOUI onto this page synchronously?

Loading OOUI in a render-blocking way seems a bit extreme, and I'm not sure RL even lets you do that any more.

Loading OOUI in a render-blocking way seems a bit extreme, and I'm not sure RL even lets you do that any more.

You load the CSS synchronously - which is all you would need to show a progress bar.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 11:14 PM