Page MenuHomePhabricator
Create Task
Maniphest T142297

Search results discard first letter of fragment identifiers
Closed, ResolvedPublic
Actions

Description

When the search results include links to page fragments (with the hash notation), the first letter of the hash identifier is discarded.
For example:
https://test2.wikipedia.org/w/index.php?search=find+areas
returns a link to /wiki/Calculus#ow_to_use_Integral_Calculus_to_find_Areas: notice the missing H after the hash sign. Fixing the URL manually leads to the correct place in the page.

Details

SubjectRepoBranchLines +/-
Use createFragmentTarget instead of setFragmentmediawiki/extensions/CirrusSearchwmf/1.28.0-wmf.13+1 -4
Use createFragmentTarget instead of setFragmentmediawiki/extensions/CirrusSearchmaster+1 -4
Customize query in gerrit

Related Objects

Event Timeline

Cigaes created this task.Aug 6 2016, 3:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2016, 3:11 PM
Danny_B triaged this task as Unbreak Now! priority.Aug 6 2016, 3:14 PM
Danny_B edited projects, added MediaWiki-Special-pages, MediaWiki-Search, Regression; removed MediaWiki-General.
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptAug 6 2016, 3:14 PM
Restricted Application added subscribers: Luke081515, TerraCodes. · View Herald Transcript
Aklapper edited projects, added CirrusSearch; removed MediaWiki-Search, MediaWiki-Special-pages.Aug 7 2016, 12:37 PM
Aklapper merged a task: T142319: Invalid section links in search results.
Aklapper added a subscriber: RobinHood70.
dcausse claimed this task.Aug 8 2016, 8:28 AM
dcausse merged a task: T142351: Links to sections in search results are all wrong, missing the first letter.
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
dcausse added a subscriber: Schnark.
gerritbot subscribed.Aug 8 2016, 8:43 AM

Change 303518 had a related patch set uploaded (by DCausse):
Add a leading # when calling setFragment

https://gerrit.wikimedia.org/r/303518

dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Aug 8 2016, 8:43 AM
greg subscribed.Aug 8 2016, 5:50 PM

This is UBN! and appears to be affecting production. What is the status and timeline for resolution?

• Deskana added subscribers: TJones, Smalyshev, • Deskana.Aug 8 2016, 5:53 PM

@Smalyshev @TJones Can you review the above patch, please? If it fixes the issue, we need to get this deployed.

dcausse added a comment.Aug 8 2016, 5:54 PM

@greg trying to get this patch reviewed and applied asap so we can swat today.

gerritbot added a comment.Aug 8 2016, 6:32 PM

Change 303518 merged by jenkins-bot:
Use createFragmentTarget instead of setFragment

https://gerrit.wikimedia.org/r/303518

gerritbot added a comment.Aug 8 2016, 6:32 PM

Change 303597 had a related patch set uploaded (by DCausse):
Use createFragmentTarget instead of setFragment

https://gerrit.wikimedia.org/r/303597

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)).Aug 8 2016, 7:00 PM
debt subscribed.Aug 8 2016, 7:15 PM

thanks for the quick fix everyone!

dcausse added a comment.Aug 8 2016, 7:29 PM

Patch for wmf13 branch (https://gerrit.wikimedia.org/r/303597) added to morning swat tomorrow (Aug 9).

dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Aug 8 2016, 7:30 PM
greg added a comment.Aug 8 2016, 8:05 PM
In T142297#2534660, @dcausse wrote:

Patch for wmf13 branch (https://gerrit.wikimedia.org/r/303597) added to morning swat tomorrow (Aug 9).

If someone is around, there is also the evening swat window in a little less than 3 hours. If it is UBN! (I'm not sure, it wasn't set by someone on Discovery) then it should probably be... now, yes? :)

• Deskana added a comment.Aug 8 2016, 8:16 PM
In T142297#2534823, @greg wrote:
In T142297#2534660, @dcausse wrote:

Patch for wmf13 branch (https://gerrit.wikimedia.org/r/303597) added to morning swat tomorrow (Aug 9).

If someone is around, there is also the evening swat window in a little less than 3 hours. If it is UBN! (I'm not sure, it wasn't set by someone on Discovery) then it should probably be... now, yes? :)

Getting it done today would be ideal. That said, it only breaks a small number of searches and only breaks them in a fairly minor way, so it's not the worst thing in the world if it does have to wait until tomorrow.

greg lowered the priority of this task from Unbreak Now! to High.Aug 8 2016, 8:23 PM

Per Dan.

gerritbot added a comment.Aug 9 2016, 3:09 PM

Change 303597 merged by jenkins-bot:
Use createFragmentTarget instead of setFragment

https://gerrit.wikimedia.org/r/303597

Stashbot subscribed.Aug 9 2016, 3:18 PM

Mentioned in SAL [2016-08-09T15:18:46Z] <thcipriani@tin> Synchronized php-1.28.0-wmf.13/extensions/CirrusSearch/includes/Search/Result.php: SWAT: [[gerrit:303597|Use createFragmentTarget instead of setFragment (T142297)]] (duration: 00m 54s)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Aug 9 2016, 4:00 PM
Aklapper added a comment.Aug 11 2016, 12:12 PM

Deployed it seems.

Can this task be closed as resolved or what's missing here?

dcausse closed this task as Resolved.Aug 11 2016, 12:16 PM

Thanks for the heads up @Aklapper
The fix was deployed on all wikis, closing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL