Page MenuHomePhabricator

Errors shown in tux are not cleared after a successful save
Closed, ResolvedPublic


I hit the title blacklist while attempting to save a translation so it showed an error. After disabling title blacklist, I tried to save the page again and it got successfully saved this time. However, the error which was shown at the top of the edit box still persists there. (Note: you can reproduce this for other errors too, not just title blacklist errors). I would expect the error to be cleared once it's successfully saved.
Also another related thing which doesn't work as expected is: If there were several errors shown on successive save attempts, the latest error is shown at the bottom instead of the top and you need to click on the "N more" to find the actual error for the latest attempt. It should have a better behavior than that.

Event Timeline

Glaisher created this task.Aug 7 2016, 10:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2016, 10:15 AM

Change 303529 had a related patch set uploaded (by Glaisher):
ext.translate.editor: Improve behavior of displaying warnings

Change 303529 merged by jenkins-bot:
ext.translate.editor: Improve behavior of displaying warnings

Nikerabbit closed this task as Resolved.Aug 9 2016, 8:02 AM
Nikerabbit assigned this task to Glaisher.
Nikerabbit triaged this task as Normal priority.
Nikerabbit added a subscriber: Nikerabbit.

I believe this is done. Feel free to re-open if you had more in mind.