Page MenuHomePhabricator
Create Task
Maniphest T142392

Convert all extensions and skins to manifest_version 2
Open, LowestPublic
Actions

Description

This is a task for tracking all extensions and skins being converted to manifest_version 2

We should probably update the docs on how to convert to, and also without using the maintenance script.

Details

SubjectRepoBranchLines +/-
Convert to manifest_version 2mediawiki/extensions/SecurityApimaster+10 -5
Update schema to manifest_version 2mediawiki/extensions/FundraisingEmailUnsubscribemaster+69 -39
New version 1.2mediawiki/extensions/HoverGallerymaster+4 K -245
Update skin.json to manifest_version version 2mediawiki/skins/Metrolookmaster+57 -21
Update manifest_version to version 2mediawiki/extensions/WikimediaIncubatormaster+80 -58
Update manifest_version to version 2mediawiki/extensions/SemanticFormsmaster+88 -41
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT142392 Convert all extensions and skins to manifest_version 2
 OpenNoneT234114 Update extension.json files to manifest_version 2 to use description instead of @globalname documentation
 ResolvedKizuleT239433 Convert UniversalLanguageSelector extension.json to manifest_version 2
 Resolvedminhducsun2002T241200 Convert Cognate extension.json to manifest_version 2
 ResolvedtaaviT241199 Convert CentralAuth extension.json to manifest_version 2
 Resolvedminhducsun2002T241201 Convert ContentTranslation extension.json to manifest_version 2
 ResolvedAmmarpadT241203 Convert InterwikiSorting extension.json to manifest_version 2
 ResolvedJeremyNguyenGCIT241204 Convert OAuthAuthentication extension.json to manifest_version 2
 ResolvedKizuleT241205 Convert SiteMatrix extension.json to manifest_version 2
 ResolvedAmmarpadT241892 Update RelatedArticle extension.json to manifest version 2
 ResolvedtaaviT241896 Update GPGMail extension.json to manifest version 2
 ResolvedArcaynT241897 Update IDS extension.json to manifest version 2
 ResolvedBrandonXLFT241899 Update Lingo extension.json to manifest version 2
 ResolvedtaaviT241900 Update WikidataPageBanner extension.json to manifest version 2
 ResolvedReedyT252470 Update extension.json files to manifest_version 2 in WMF deployed extensions
 ResolvedSodaT241898 Update QuickSurveys extension.json to manifest version 2
 DeclinedRetroCraftT241894 Update WikimediaEvents extension.json to manifest version 2
 ResolvedReedyT252475 Convert Renameuser extension.json to manifest_version 2
 ResolvedReedyT252472 Update skin.json files to manifest_version 2 in WMF deployed skins

Event Timeline

Paladox created this task.Aug 8 2016, 3:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2016, 3:24 PM
Reedy added a comment.Aug 8 2016, 3:39 PM

Why? What do we gain for extensions already on v1?

Any new extensions converted will go to v2

Doing it via script seems more sensible to me for config stuff, where they go to having a value... It's labour intensive for little gain

Reedy added a project: MediaWiki-extensions-General.Aug 8 2016, 3:40 PM
gerritbot subscribed.Aug 9 2016, 4:39 PM

Change 303818 had a related patch set uploaded (by Paladox):
Update skin.json to manifest_version version 2

https://gerrit.wikimedia.org/r/303818

gerritbot added a comment.Aug 9 2016, 4:45 PM

Change 303819 had a related patch set uploaded (by Paladox):
Update manifest_version to version 2

https://gerrit.wikimedia.org/r/303819

gerritbot added a comment.Aug 9 2016, 4:57 PM

Change 303823 had a related patch set uploaded (by Paladox):
Update manifest_version to version 2

https://gerrit.wikimedia.org/r/303823

gerritbot added a comment.Aug 9 2016, 5:38 PM

Change 303823 merged by Yaron Koren:
Update manifest_version to version 2

https://gerrit.wikimedia.org/r/303823

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).Aug 9 2016, 6:00 PM
Reedy triaged this task as Lowest priority.Aug 9 2016, 7:43 PM
Legoktm added a comment.Aug 9 2016, 7:48 PM

I don't think we should be encouraging a mass-conversion type thing. New extensions should use v2, and but unless they need one of the new features included in v2 (currently only file config options), there's no benefit, and just a loss of backwards-compatibility.

It is likely that we will start adding features that require v2 (*cough* config db *cough*), at which point we should begin encouraging people to update to version 2.

gerritbot added a comment.Aug 21 2016, 6:56 PM

Change 303818 merged by jenkins-bot:
Update skin.json to manifest_version version 2

https://gerrit.wikimedia.org/r/303818

gerritbot added a comment.Aug 27 2016, 12:31 AM

Change 307044 had a related patch set (by Paladox) published:
Update schema to manifest_version 2

https://gerrit.wikimedia.org/r/307044

gerritbot added a project: Patch-For-Review.Aug 27 2016, 12:31 AM
gerritbot added a comment.Oct 16 2016, 7:30 PM

Change 303819 abandoned by Reedy:
Update manifest_version to version 2

https://gerrit.wikimedia.org/r/303819

Reedy added a comment.Nov 2 2016, 12:14 AM
In T142392#2533512, @Reedy wrote:

Why? What do we gain for extensions already on v1?

Any new extensions converted will go to v2

Doing it via script seems more sensible to me for config stuff, where they go to having a value... It's labour intensive for little gain

In T142392#2537846, @Legoktm wrote:

I don't think we should be encouraging a mass-conversion type thing. New extensions should use v2, and but unless they need one of the new features included in v2 (currently only file config options), there's no benefit, and just a loss of backwards-compatibility.

It is likely that we will start adding features that require v2 (*cough* config db *cough*), at which point we should begin encouraging people to update to version 2.

Oh look, and now we have T149757 and T149759, meaning speeding this through would've been a waste of time :)

Reedy changed the task status from Open to Stalled.Nov 2 2016, 12:15 AM
Reedy removed projects: Patch-For-Review, MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).
Dereckson mentioned this in T151842: Create a branch REL1_28 for Metrolook (skin) to prevent Manifest version 2 issue.Nov 29 2016, 7:12 AM
Jdforrester-WMF moved this task from Backlog to Extension registration manifest_version 2 on the MediaWiki-Configuration board.Nov 30 2016, 11:14 PM
gerritbot added a comment.Nov 29 2018, 8:36 AM

Change 476457 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/HoverGallery@master] New version 1.2

https://gerrit.wikimedia.org/r/476457

gerritbot added a project: Patch-For-Review.Nov 29 2018, 8:36 AM
gerritbot added a comment.Nov 30 2018, 12:13 PM

Change 476457 abandoned by Zoranzoki21:
New version 1.2

https://gerrit.wikimedia.org/r/476457

gerritbot added a comment.Dec 11 2019, 2:23 AM

Change 476457 restored by Zoranzoki21:
New version 1.2

Reason:
Let me try again

https://gerrit.wikimedia.org/r/476457

gerritbot added a comment.Dec 11 2019, 3:07 AM

Change 476457 abandoned by Zoranzoki21:
New version 1.2

Reason:
Hmm, there isn't edit button

https://gerrit.wikimedia.org/r/476457

gerritbot added a comment.Dec 11 2019, 3:07 AM

Change 476457 restored by Zoranzoki21:
New version 1.2

Reason:
Refresh

https://gerrit.wikimedia.org/r/476457

gerritbot added a comment.Dec 11 2019, 3:07 AM

Change 476457 abandoned by Zoranzoki21:
New version 1.2

Reason:
I should create new patch

https://gerrit.wikimedia.org/r/476457

gerritbot added a comment.Dec 11 2019, 3:16 AM

Change 476457 restored by Zoranzoki21:
New version 1.2

Reason:
Second test

https://gerrit.wikimedia.org/r/476457

gerritbot added a comment.Dec 28 2019, 9:15 AM

Change 476457 abandoned by Zoranzoki21:
New version 1.2

Reason:
Let's start from zero

https://gerrit.wikimedia.org/r/476457

gerritbot added a comment.Apr 7 2020, 3:54 AM

Change 307044 abandoned by Jforrester:
Update schema to manifest_version 2

Reason:
Let's re-generate this rather than start now.

https://gerrit.wikimedia.org/r/307044

Aklapper removed a project: Patch-For-Review.Jun 24 2020, 2:10 PM

Should this task still be opened? If yes, what exactly is this stalled on?

Reedy changed the task status from Stalled to Open.EditedJun 24 2020, 4:13 PM
In T142392#6252709, @Aklapper wrote:

Should this task still be opened? If yes, what exactly is this stalled on?

I think this was because of

In T142392#2533512, @Reedy wrote:

Doing it via script seems more sensible to me for config stuff, where they go to having a value... It's labour intensive for little gain

But we have a script now! And did before I stalled it

rMW83ec5909d463: registration: Convert "config" into an object with metadata

Though, also,

In T142392#2761964, @Reedy wrote:
In T142392#2533512, @Reedy wrote:

Why? What do we gain for extensions already on v1?

Any new extensions converted will go to v2

Doing it via script seems more sensible to me for config stuff, where they go to having a value... It's labour intensive for little gain

In T142392#2537846, @Legoktm wrote:

I don't think we should be encouraging a mass-conversion type thing. New extensions should use v2, and but unless they need one of the new features included in v2 (currently only file config options), there's no benefit, and just a loss of backwards-compatibility.

It is likely that we will start adding features that require v2 (*cough* config db *cough*), at which point we should begin encouraging people to update to version 2.

Oh look, and now we have T149757 and T149759, meaning speeding this through would've been a waste of time :)

T149757: Remove manifest_version 2 from REL1_28 and T149759: Downgrade extensions that use manifest_version 2 in REL1_28 would've meant it was pointless doing so at the time

Reedy added a subtask: T234114: Update extension.json files to manifest_version 2 to use description instead of @globalname documentation.Jun 24 2020, 4:13 PM
gerritbot added a comment.Apr 9 2022, 3:09 PM

Change 778618 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/SecurityApi@master] Convert to manifest_version 2

https://gerrit.wikimedia.org/r/778618

gerritbot added a project: Patch-For-Review.Apr 9 2022, 3:09 PM
gerritbot added a comment.Apr 9 2022, 5:13 PM

Change 778618 merged by jenkins-bot:

[mediawiki/extensions/SecurityApi@master] Convert to manifest_version 2

https://gerrit.wikimedia.org/r/778618

Zabe mentioned this in rESAP1c49283e7cfc: Convert to manifest_version 2.Apr 9 2022, 5:13 PM
Pppery removed a project: Patch-For-Review.Oct 21 2023, 11:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits