Page MenuHomePhabricator

TemplateData help link is a frameless button, rather than simply a link
Closed, ResolvedPublic1 Story Points

Description

In ext.templateDataGenerator.ui.js, the documentation link (templatedata-helplink) isn't wikified, so users tend to not notice it or to not think it is clickable.
(That help link is shown when we edit a template or its documentation).

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 9 2016, 3:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
The_RedBurn updated the task description. (Show Details)Aug 9 2016, 3:36 PM

Change 304487 had a related patch set uploaded (by DLynch):
Flag the help button as progressive

https://gerrit.wikimedia.org/r/304487

DLynch added a subscriber: DLynch.Aug 12 2016, 5:02 PM

304487 gets us:

Thank you, it already looks much better.
But it seems like a hack.

By looking at how it's done for the link inside the template tool, I found out that removing the class "oo-ui-buttonElement-button" from the <a> tag seems to do it.
Here's the link to the source: https://phabricator.wikimedia.org/diffusion/EVED/browse/master/modules/ve-mw/ui/pages/ve.ui.MWTemplatePage.js;c707ab02b4ff32fff6313af3bec0437f0a67f8dd$66

Jdforrester-WMF renamed this task from TemplateData help link is not wikified to TemplateData help link is a frameless button, rather than simply a link.Aug 18 2016, 12:13 AM
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF set the point value for this task to 1.

Change 304487 merged by jenkins-bot:
Make the help button a help link again

https://gerrit.wikimedia.org/r/304487