Page MenuHomePhabricator
Create Task
Maniphest T142521

Search box massively misaligned on desktop view on Android devices (and probably other mobile devices too)
Closed, DeclinedPublic
Actions

Description

Steps to reproduce:

  • Acquire suitable Android device (e.g. Nexus 5)
  • Make sure "Request desktop mode" is enabled
  • Go to https://en.wikipedia.org/wiki/Main_Page
  • Tap on the search box; the page will zoom in somewhat (see screenshot 1 below)
  • Type something into the search box

Expected:

  • There are some search results displayed

Actual:

  • There are no search results displayed (see screenshot 2 below)

Screenshot_20160809-130758.png (1×1 px, 239 KB)
Screenshot_20160809-130926.png (1×1 px, 223 KB)

Details

SubjectRepoBranchLines +/-
Fix misaligned search box on mobile devices viewing in desktop modemediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

• Deskana created this task.Aug 9 2016, 8:13 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptAug 9 2016, 8:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Deskana added a subscriber: Catrope.Aug 9 2016, 8:13 PM

Thanks to some excellent debugging help from @Catrope, we figured out that the problem is that MediaWiki isn't taking into account the scrolling behaviour, and therefore is misaligning the search box to be off-screen.

gerritbot subscribed.Aug 9 2016, 8:16 PM

Change 303864 had a related patch set uploaded (by Deskana):
Fix misaligned search box on mobile devices viewing in desktop mode

https://gerrit.wikimedia.org/r/303864

• Deskana claimed this task.Aug 9 2016, 8:16 PM
• Deskana triaged this task as Medium priority.
• Deskana moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.

I've asked @Catrope to review this patch, since he has expertise in this and also helped me figure it out.

debt removed a project: Discovery-Search.Aug 10 2016, 10:54 PM
• ksmith subscribed.Aug 30 2016, 10:03 PM

@Catrope @Deskana : Any progress on this?

• Deskana added a comment.Aug 30 2016, 10:57 PM
In T142521#2596156, @ksmith wrote:

@Catrope @Deskana : Any progress on this?

None, sadly. I'm stuck unable to reproduce both Bartosz's issue with the box being misplaced and also Erik's issue that the patch doesn't fix the problem in question. I do not know how to proceed.

• Deskana removed • Deskana as the assignee of this task.Oct 11 2016, 5:15 PM

I don't have the capacity to keep working on this.

• ksmith added a subscriber: • JKatzWMF.Oct 11 2016, 5:22 PM

Is this something that folks in Reading would want to take on? Pinging @JKatzWMF.

• Deskana moved this task from Needs review to Incoming on the Discovery-Search (Current work) board.Nov 1 2016, 5:03 PM
• Deskana added a comment.Nov 15 2016, 6:17 PM

Realistically this isn't being worked on right now by Discovery. Removing from current work.

• Deskana moved this task from Current work to search-icebox on the Discovery-Search board.Nov 15 2016, 6:17 PM
• Deskana edited projects, added Discovery-Search; removed Discovery-Search (Current work).
gerritbot added a comment.Jun 26 2017, 6:04 PM

Change 303864 abandoned by Deskana:
Fix misaligned search box on mobile devices viewing in desktop mode

Reason:
This has not been touched in quite some time.

https://gerrit.wikimedia.org/r/303864

Jdlrobson closed this task as Declined.Jan 11 2022, 4:57 PM
Jdlrobson subscribed.

We are phasing out this search (see new WVUI search) so seems like this can be closed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL