Page MenuHomePhabricator

WikiLove doesn't work with Refreshed
Open, Needs TriagePublic

Description

When clicking on WikiLove in the Refreshed toolbar (via "more" which brings up a menu of other actions), it simply adds a hash to the end of the URL and doesn't pull up the usual modal for choosing which WikiLove to give.

Related Objects

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 9 2016, 10:20 PM
Restricted Application added a subscriber: MacFan4000. · View Herald Transcript
SamanthaNguyen moved this task from Backlog to Refreshed on the Brickimedia board.Aug 9 2016, 10:21 PM
SamanthaNguyen moved this task from Backlog to Bugs on the Refreshed board.

When you have WikiLove enabled in your preferences, the init JS is added (via the function that's hooked to BeforePageDisplay) to the page source correctly. That JS, as you can see, merely calls the actual WikiLove JS...which, as we can see by looking at the init function, is essentially making a wild and incorrect assumption that either skins are MonoBook/Vector clones with the similar IDs and classes or then they're ancient legacy MW skins (like Cologne Blue etc.). Since on Refreshed the ca-wikilove element is on the <a> itself rather than on the parent element of the <a> , both selectors will fail and thus no click handler is registered.

Readding WikiLove to get some input from upstream as this is (IMHO) more of a WikiLove bug than (just) a Refreshed bug.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 13 2016, 1:08 AM

Is there/what is the skin-agnostic way to get the <a> tag associated with ca-wikilove?

SamanthaNguyen added a comment.EditedOct 14 2016, 9:40 PM

@lcf119 We can always make a pull request to WikiLove and have the commit code-reviewed :) Edit: I'd also like to point out that removing WikiLove from the Refreshed dropdown menu doesn't solve the bug, it's more of a hacky workaround (and the bug would still exist).

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 26 2019, 8:37 AM