MediaWiki theme: ButtonSelect-, ButtonGroup- and ToggleButtonWidget's selected buttons should feature border-color equal to background-color for crispier look
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Aug 10 2016, 3:37 AM

Description

In a conversation with @Nirzar earlier today we've identified a minor UI issue with selected buttons in ButtonSelectWidget (as of v0.17.7).
The selected state with the normal border-color lets the button appear blurry.

It is better to make the border-color equal to the background-color.

Before	After

Details

	Subject	Repo	Branch	Lines +/-
	MediaWiki theme: Clear border on selected framed buttons	oojs/ui	master	+29 -13

Customize query in gerrit

Event Timeline

Volker_E created this task.Aug 10 2016, 3:37 AM

Restricted Application added a project: UI-Standardization. · View Herald TranscriptAug 10 2016, 3:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Volker_E updated the task description. (Show Details)Aug 10 2016, 3:41 AM

Volker_E added a subscriber: Esanders.

Change 303973 had a related patch set uploaded (by VolkerE):
MediaWiki theme: ButtonSelectWidget's selected buttons with clearer border

https://gerrit.wikimedia.org/r/303973

Volker_E renamed this task from MediaWiki theme: ButtonSelectWidget selected buttons should feature background-color in border as well to MediaWiki theme: ButtonSelect-/ButtonGroupWidget selected buttons should feature background-color on border.Aug 10 2016, 1:58 PM

Volker_E updated the task description. (Show Details)

matmarex updated the task description. (Show Details)Aug 10 2016, 6:46 PM

Volker_E renamed this task from MediaWiki theme: ButtonSelect-/ButtonGroupWidget selected buttons should feature background-color on border to MediaWiki theme: ButtonSelect-, ButtonGroup- and ToggleButtonWidget's selected buttons should feature border-color equal to background-color for crispier look.Aug 10 2016, 10:08 PM

Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.

Volker_E added a project: Patch-For-Review.

matmarex updated the task description. (Show Details)Aug 10 2016, 10:42 PM

Change 303973 merged by jenkins-bot:
MediaWiki theme: Clear border on selected framed buttons

https://gerrit.wikimedia.org/r/303973

Volker_E closed this task as Resolved.Aug 11 2016, 12:11 AM

Volker_E removed a project: Patch-For-Review.

Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.

Volker_E moved this task from Backlog to OOjs-UI-0.17.8 on the OOUI board.Aug 11 2016, 12:14 AM

Volker_E edited projects, added OOUI (OOjs-UI-0.17.8); removed OOUI.

	F4349541: T142550 ButtonSelectWidget OOjs UI Demos 2016-08-09.png
	Aug 10 2016, 3:41 AM

MediaWiki theme: ButtonSelect-, ButtonGroup- and ToggleButtonWidget's selected buttons should feature border-color equal to background-color for crispier lookClosed, ResolvedPublicActions

Description

Details

Event Timeline

MediaWiki theme: ButtonSelect-, ButtonGroup- and ToggleButtonWidget's selected buttons should feature border-color equal to background-color for crispier look
Closed, ResolvedPublic
Actions