Page MenuHomePhabricator
Create Task
Maniphest T142610

Change i18n in the iOS app to be "Publish" rather than "Save" where appropriate
Closed, ResolvedPublic
Actions

Description

Per the parent; we're expecting to do this on the site in the first week of September, so any time after that would be great.

(This'll also distinguish more clearly between saved offline pages and images against publishing online changes to pages, which is nice.)

From https://github.com/wikimedia/wikipedia-ios/blob/master/Wikipedia/Localizations/en.lproj/Localizable.strings I think the main strings to change are:

  • wikitext-upload-save
  • navbar-title-mode-edit-wikitext-save
  • navbar-title-mode-login-and-save
  • navbar-title-mode-create-account-and-save
  • button-save

For consistency, ideally we'd also change:

  • wikitext-upload-save-anonymously
  • abuse-filter-warning-heading
  • abuse-filter-disallow-heading

And possibly some places I missed.

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Aug 10 2016, 6:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2016, 6:05 PM
• JMinor added a project: iOS-app-v5.2.0-Honey.Aug 10 2016, 6:08 PM

Thanks @Jdforrester-WMF we'll aim to get this in our early September release.

• JMinor removed the point value for this task.Aug 10 2016, 6:09 PM
• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.2.0-Honey board.
• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Aug 11 2016, 12:02 AM
Liuxinyu970226 subscribed.Aug 17 2016, 2:01 AM
• JMinor moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v5.2.0-Honey board.Sep 7 2016, 5:18 PM
Mhurd claimed this task.Sep 8 2016, 6:28 PM
Mhurd moved this task from Ready for Development to Doing on the iOS-app-v5.2.0-Honey board.
Mhurd added a comment.Sep 8 2016, 7:00 PM

https://github.com/wikimedia/wikipedia-ios/pull/875

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.2.0-Honey board.Sep 8 2016, 7:01 PM
• Fjalapeno mentioned this in rAPIOSef7fc3ccb6f5: Merge pull request #875 from wikimedia/feature/save-to-publish/T142610.Sep 8 2016, 7:47 PM
• Fjalapeno moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.2.0-Honey board.Sep 8 2016, 7:57 PM
• JMinor moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.2.0-Honey board.Sep 8 2016, 11:32 PM
Nicholas.tsg subscribed.EditedSep 10 2016, 12:34 AM

Testing on App version: 920.1, OS version: iOS 10.0.1 (14A403), Device: iPhone 6S.
Since there were no list of all the areas that may have been changed, I checked only one article on English Wikipedia, it shows a change from wording that it now says "Publish" so hopefully all other areas are fixed too. (I did not save/publish any changes.)

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.2.0-Honey board.Sep 10 2016, 12:35 AM
• JMinor added a comment.Sep 14 2016, 5:07 PM

@Jdforrester-WMF after our discussion, I discovered this had already been merged and tested. Rather than revert I let it out into the world. Nobody has said anything, so hopefully we didn't ruin your plans.

• JMinor closed this task as Resolved.Sep 14 2016, 5:07 PM
Liuxinyu970226 unsubscribed.Sep 14 2016, 9:59 PM
RandomDSdevel awarded a token.Oct 21 2016, 4:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL