Page MenuHomePhabricator

Paste fails if contents contains a data:uri image
Closed, ResolvedPublic1 Story Points

Description

VE assumes any HTML paste containing a data:uri image is a Firefox user pasting an image in, so triggers image upload code (which currently does nothing). We should restrict this to just pastes which contain /only/ image nodes.

Event Timeline

Esanders created this task.Aug 10 2016, 7:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2016, 7:30 PM

Change 304056 had a related patch set uploaded (by Esanders):
Move image-paste blocking to transfer handler match function

https://gerrit.wikimedia.org/r/304056

Change 304058 had a related patch set uploaded (by Esanders):
Only trigger Firefox data:uri image paste if there is no other HTML

https://gerrit.wikimedia.org/r/304058

Jdforrester-WMF closed this task as Resolved.Aug 10 2016, 9:46 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

Change 304058 merged by jenkins-bot:
Only trigger Firefox data:uri image paste if there is no other HTML

https://gerrit.wikimedia.org/r/304058

Change 304056 merged by jenkins-bot:
Move image-paste blocking to transfer handler match function

https://gerrit.wikimedia.org/r/304056