Page MenuHomePhabricator
Create Task
Maniphest T142622

Paste fails if contents contains a data:uri image
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

VE assumes any HTML paste containing a data:uri image is a Firefox user pasting an image in, so triggers image upload code (which currently does nothing). We should restrict this to just pastes which contain /only/ image nodes.

Details

SubjectRepoBranchLines +/-
Move image-paste blocking to transfer handler match functionmediawiki/extensions/VisualEditormaster+10 -5
Only trigger Firefox data:uri image paste if there is no other HTMLVisualEditor/VisualEditormaster+6 -3
Customize query in gerrit

Event Timeline

Esanders created this task.Aug 10 2016, 7:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2016, 7:30 PM
gerritbot subscribed.Aug 10 2016, 7:47 PM

Change 304056 had a related patch set uploaded (by Esanders):
Move image-paste blocking to transfer handler match function

https://gerrit.wikimedia.org/r/304056

gerritbot added a comment.Aug 10 2016, 7:49 PM

Change 304058 had a related patch set uploaded (by Esanders):
Only trigger Firefox data:uri image paste if there is no other HTML

https://gerrit.wikimedia.org/r/304058

Jdforrester-WMF closed this task as Resolved.Aug 10 2016, 9:46 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added projects: VisualEditor-CopyPaste, MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)).
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Aug 10 2016, 10:56 PM

Change 304058 merged by jenkins-bot:
Only trigger Firefox data:uri image paste if there is no other HTML

https://gerrit.wikimedia.org/r/304058

gerritbot added a comment.Sep 12 2016, 3:55 PM

Change 304056 merged by jenkins-bot:
Move image-paste blocking to transfer handler match function

https://gerrit.wikimedia.org/r/304056

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 12 2016, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL