Page MenuHomePhabricator

FieldLayout notices/errors have large line-height, look silly for multiline text
Closed, ResolvedPublic

Assigned To
Authored By
matmarex
Aug 10 2016, 9:29 PM
Referenced Files
F4351708: pasted_file
Aug 10 2016, 9:32 PM
F4351720: pasted_file
Aug 10 2016, 9:32 PM
F4351711: pasted_file
Aug 10 2016, 9:29 PM
F4351718: pasted_file
Aug 10 2016, 9:29 PM

Description

FieldLayout notices/errors have large line-height, look silly for multiline text.

Reported by @Isarra in code review of https://gerrit.wikimedia.org/r/#/c/284902/.

pasted_file (165×714 px, 17 KB)

pasted_file (179×710 px, 18 KB)

For easy testing, run these commands in the console for "FieldLayout with notice and error message" in the demo:

layout.setErrors( [ 'Quibusdam quibusdam quia quae non. Repudiandae officia qui nostrum perferendis beatae ullam. Et voluptatum est ea quia. Velit ullam error recusandae qui. Repudiandae ab incidunt sit non nesciunt hic recusandae porro.' ] );
layout.setNotices( [ 'Quibusdam quibusdam quia quae non. Repudiandae officia qui nostrum perferendis beatae ullam. Et voluptatum est ea quia. Velit ullam error recusandae qui. Repudiandae ab incidunt sit non nesciunt hic recusandae porro.' ] );