Page MenuHomePhabricator

FieldLayout notices/errors have large line-height, look silly for multiline text
Closed, ResolvedPublic

Description

FieldLayout notices/errors have large line-height, look silly for multiline text.

Reported by @Isarra in code review of https://gerrit.wikimedia.org/r/#/c/284902/.


For easy testing, run these commands in the console for "FieldLayout with notice and error message" in the demo:

layout.setErrors( [ 'Quibusdam quibusdam quia quae non. Repudiandae officia qui nostrum perferendis beatae ullam. Et voluptatum est ea quia. Velit ullam error recusandae qui. Repudiandae ab incidunt sit non nesciunt hic recusandae porro.' ] );
layout.setNotices( [ 'Quibusdam quibusdam quia quae non. Repudiandae officia qui nostrum perferendis beatae ullam. Et voluptatum est ea quia. Velit ullam error recusandae qui. Repudiandae ab incidunt sit non nesciunt hic recusandae porro.' ] );

Event Timeline

matmarex created this task.Aug 10 2016, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2016, 9:29 PM

Change 304124 had a related patch set uploaded (by Bartosz Dziewoński):
FieldLayout: Use saner line-height for errors/notices

https://gerrit.wikimedia.org/r/304124

matmarex claimed this task.Aug 10 2016, 9:32 PM

After the patch:

Jdforrester-WMF closed this task as Resolved.Aug 10 2016, 10:59 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.17.8 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.8); removed OOUI.

Change 304124 merged by jenkins-bot:
FieldLayout: Use saner line-height for errors/notices

https://gerrit.wikimedia.org/r/304124