Page MenuHomePhabricator
Create Task
Maniphest T142779

Resolved topics should be able to be deleted or suppressed without reopening them first
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
Etonkovidova
Aug 11 2016, 10:49 PM
Tags
Referenced Files
F4354731: Screen Shot 2016-08-11 at 3.22.48 PM.png
Aug 11 2016, 10:49 PM
F4354729: Screen Shot 2016-08-11 at 3.15.14 PM.png
Aug 11 2016, 10:49 PM
Subscribers
Aklapper
Catrope
Etonkovidova
Framawiki
gerritbot
Jules78120
• Mattflaschen-WMF
View All 10 Subscribers

Description

  1. As a user who can edit other users' post, log in to betalabs, and "Mark as resolved" some of topics on the Flow board.
  2. Then, click on the '# comment" under the title of the topic that you've just resolved - the option 'Delete' will be displayed. For some users, there will be 'Suppress' option too.
  3. Click on 'Delete' or 'Suppress' option and enter some text into 'Please explain..." and click to confirm the action - the warning appears "This topic is resolved, so further activity is not possible."

Screen Shot 2016-08-11 at 3.22.48 PM.png (324×1 px, 31 KB)

Screen Shot 2016-08-11 at 3.15.14 PM.png (509×1 px, 76 KB)

Details

SubjectRepoBranchLines +/-
Allow moderating resolved topicmediawiki/extensions/Flowmaster+63 -12
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Aug 11 2016, 10:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2016, 10:49 PM
Catrope renamed this task from Resolved topics display non-functional Delete/Suppress options for posts to Resolved topics should be able to be deleted or suppressed without reopening them first.Aug 15 2016, 9:06 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collab-Team-Q1-July-Sep-2016 board.
Catrope subscribed.

The issue here IMO is that deleting and resolving resolved topics should not be blocked, it should be allowed. You can work around this by reopening the topic first but you shouldn't have to.

Etonkovidova added a comment.Aug 16 2016, 8:50 PM

Two issues are described here

  • (from the issue description) posts in resolved topics have options 'Delete' and 'Suppress'. When clicked, those options cannot be performed unless the topics is re-open.
  • (from @Catrope comment) resolved topics should have options Delete and Suppress, so the resolved topics can be deleted/suppressed without re-opening them.
gerritbot subscribed.Sep 2 2016, 1:26 AM

Change 308116 had a related patch set uploaded (by Sbisson):
Allow moderating resolved topic

https://gerrit.wikimedia.org/r/308116

gerritbot added a project: Patch-For-Review.Sep 2 2016, 1:26 AM
SBisson claimed this task.Sep 2 2016, 1:35 AM
SBisson moved this task from Ready for Pickup to Needs Review on the Collab-Team-Q1-July-Sep-2016 board.
gerritbot added a comment.Sep 2 2016, 1:48 AM

Change 308116 merged by jenkins-bot:
Allow moderating resolved topic

https://gerrit.wikimedia.org/r/308116

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)).Sep 2 2016, 2:00 AM
SBisson moved this task from Needs Review to QA Review on the Collab-Team-Q1-July-Sep-2016 board.Sep 2 2016, 10:25 AM
Etonkovidova added a comment.Sep 2 2016, 6:02 PM

Checked in betalabs

  • resolved topics can be deleted/suppressed without re-opening them
  • comments in resolved topics can also be deleted/suppressed without re-opening a topic
Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Sep 2 2016, 7:14 PM
Catrope merged a task: T115209: Not possible to moderate a resolved topic without reopening.Sep 21 2016, 11:43 PM
Catrope added a subscriber: Quiddity.
Catrope merged a task: T136145: Make it possible to moderate Topics when they are solved.Sep 22 2016, 12:06 AM
Catrope added subscribers: Trizek-WMF, Framawiki, Jules78120, Zppix.
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collab-Team-Q1-July-Sep-2016.Oct 5 2016, 6:29 PM
• jmatazzoni moved this task from Untriaged to Product Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Oct 5 2016, 6:31 PM
• jmatazzoni closed this task as Resolved.Oct 11 2016, 12:38 AM
Framawiki reopened this task as Open.Nov 1 2016, 5:46 PM

Hello, on frwiki for some time I cannot again hide flow topics if they are closed, the "hide" button is not visible in the "..." menu.

Trizek-WMF closed this task as Resolved.Nov 2 2016, 2:20 PM
In T142779#2760668, @Framawiki wrote:

Hello, on frwiki for some time I cannot again hide flow topics if they are closed, the "hide" button is not visible in the "..." menu.

I've checked what is supposed to work as defined on T142779#2605500 on mediawiki.org where I'm a sysop:

  • resolved topics can be deleted/suppressed without re-opening them: works
  • comments in resolved topics can also be deleted/suppressed without re-opening a topic: works

@Framawiki, "hide" option ("cacher") is not included on these options (see the documentation).

Etonkovidova added a subscriber: • Mattflaschen-WMF.Nov 15 2016, 10:16 PM

@Framawiki and @Trizek-WMF - to address the issue of being able to hide resolved topics, T150368: Can not hide topic if it is currently resolved was filed by @Mattflaschen-WMF

Etonkovidova mentioned this in T150368: Can not hide topic if it is currently resolved.Nov 15 2016, 10:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL