Page MenuHomePhabricator

New thank dialog should have some return button to go back on diff/history page
Closed, DuplicatePublic

Description

The Special:Thanks/xxxxx page is sometimes seen if an editor clicked the "Thank" link, before the relevant JavaScript had finished loading.
(It can also be seen if the editor is not using JavaScript at all (either voluntarily, or because they're using an old or incompatible browser). But usually the first.)
There are similar cases (for identical reasons - clicking too fast) with the Watchlist stars/tabs, and the Notifications badges.

However this case is a problem, because it doesn't take the editor back to a useful destination. They would have to click [Back] twice in their browser.
Here are the steps, which can easily be reproduced just by clicking "Thank" as soon as it is visible (without waiting for the page to finish loading)

Selection_004.png (366×878 px, 121 KB)

Selection_003.png (366×878 px, 73 KB)

Selection_0022.png (366×878 px, 73 KB)

Instead, we should link to the page where the "thank" link was originally clicked on, so that the editor can navigate back there. (The primary intent of this page is for non-JavaScript users. It is only accidentally encountered by other users).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Can you clarify which dialog you're referring to...? I don't think anything new has been added recently...

Steps to reproduce:

  1. Thank for some edit on cswiki.
  2. Yesterday it openned a browser's default confirm dialog to confirm and returned the user back to history page (or other page where thank link was present) after confirmation.
  3. Today it opens MW own confirm dialog, but does not return user back to history page.

I'll put a detailed explanation in the description.

How do we know if the user clicked thank from a history or diff view? We would need to basically encode the current URL in every no-JS fallback link just to send them backwards...