Page MenuHomePhabricator
Create Task
Maniphest T142889

TemplateData: renaming parameters causes error
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  1. Open TemplateData editor.
  2. Create a new property, giving it a name. ("Foo")
  3. Immediately click the property to edit it.
  4. Change its name, ("FooBar").
  5. Observe error being thrown after your second keystroke while renaming:
ext.templateDataGenerator.data.js?3292a:719 Uncaught TypeError: Cannot set property 'name' of undefined mw.TemplateData.Model.setParamProperty @ ext.templateDataGenerator.data.js?3292a:719
mw.TemplateData.Dialog.onParamPropertyInputChange @ ext.templateDataGenerator.ui.tdDialog.js?a0610:465
oo.EventEmitter.emit @ oojs.jquery.js?d40c1:775

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Dialog must listen for changes to the param namesDLynchmediawiki/extensions/TemplateDatamaster+16 -0
Customize query in gerrit

Related Objects

Event Timeline

DLynch created this task.Aug 13 2016, 12:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2016, 12:17 AM
gerritbot subscribed.Aug 13 2016, 12:32 AM

Change 304594 had a related patch set uploaded (by DLynch):
Dialog must listen for changes to the param names

https://gerrit.wikimedia.org/r/304594

gerritbot added a project: Patch-For-Review.Aug 13 2016, 12:32 AM
• AlexMonk-WMF subscribed.Aug 14 2016, 5:43 PM

See also T141574

• AlexMonk-WMF added a comment.Aug 15 2016, 4:41 PM

I tested and, although the patch fixes this bug, it doesn't fix the other one. I'll look into the other later.

gerritbot added a comment.Aug 15 2016, 4:42 PM

Change 304594 merged by jenkins-bot:
Dialog must listen for changes to the param names

https://gerrit.wikimedia.org/r/304594

Jdforrester-WMF closed this task as Resolved.Aug 15 2016, 4:48 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited projects, added: MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)); removed: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits