Page MenuHomePhabricator

Clicking on the "Discard Changes" button causes an error on REL1_27
Closed, ResolvedPublic1 Estimated Story Points

Description

on ve.init.mw.DesktopARticleTarget.js lines 499 - 506

opened.then( function ( closing ) {
				closing.then( function ( data ) {
					if ( data && data.action === 'discard' ) {
						this.emit( 'deactivate' );
						target.cancel( trackMechanism );
					}
				} );
			} );
this.emit(..)

should be

target.emit(..)

inside the promise.

Event Timeline

Change 304882 had a related patch set uploaded (by Juanmi 1041):
Fix error when aptemting to discard changes

https://gerrit.wikimedia.org/r/304882

For general reference, this is the issue from T134794.

Change 304882 merged by Jforrester:
Fix deactivating VE after user explicitly decideas to discard changes

https://gerrit.wikimedia.org/r/304882

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This is now fixed in REL1_27, sorry!

Jdforrester-WMF set the point value for this task to 1.