overlordq wrote:

Actually I stand corrected, I think the only problem is there needs to be a space between the date and the time.

overlordq wrote:

Actually a T, to conform to ISO8601 so it should work with both pgsql and mysql:

PG:

SELECT TIMESTAMP '20071215T162455';

timestamp

2007-12-15 16:24:55

MySQL:

SELECT TIMESTAMP( '20071215T162455' ) ;

TIMESTAMP('20071215T162455')

2007-12-15 16:24:55

overlordq wrote:

Ok my last post till a dev looks at it.

Looks like MySQL stores it as a BINARY/VARBINARY O_o, so the easy fix I was envisioning isn't going to be quite so easy, so unfortunately no patch from me :-(

overlordq wrote:

I think the problem lies on line 63 of includes/ApiFeedWatchlist.php:

$endTime = wfTimestamp(TS_MW, time() - intval($params['hours'] * 60 * 60));

Unfortunately TS_MW formatted timestamps are incompatable with Postgres, would need either TS_POSTGRES or TS_ISO_8601.

(In reply to comment #4)

I think the problem lies on line 63 of includes/ApiFeedWatchlist.php:

$endTime = wfTimestamp(TS_MW, time() - intval($params['hours'] * 60 * 60));

Unfortunately TS_MW formatted timestamps are incompatable with Postgres, would
need either TS_POSTGRES or TS_ISO_8601.

Unfortunately, we store timestamps as a VARCHAR(14) in MySQL. Either the Postgres scheme should be modified to use VARCHAR(14) timestamps as well, or wfTimestamp() should provide a transparent way to convert a timestamp to whatever is needed (TS_MW for MySQL, TS_POSTGRES for Postgres).

overlordq wrote:

Proposed patch

$wgDBtype?

I quickly hacked this patch up with no regard for how efficient it would actually be. Feel free to criticize and/or suggest a better method. :)

Attached:

Done in r30030.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.