| Jdlrobson | |
| Aug 17 2016, 9:36 PM |
| F4402246: Screen Shot 2016-08-26 at 10.42.20.png | |
| Aug 26 2016, 9:45 AM |
| F4371460: Screen Shot 2016-08-17 at 2.38.11 PM.png | |
| Aug 17 2016, 9:38 PM |
Per @Nirzar
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Nirzar | T143262 Clear icon should be 75% of the size in MobileFrontend search | |||
| Invalid | • Nirzar | T144058 reduce the side padding for clear icon |
@Nirzar please put whatever priority you think is appropriate. And to be clear, this is to be applied to MF to override core's styles, not to be applied to core, correct?
Change 306796 had a related patch set uploaded (by Jdlrobson):
Clear icon should be small
This LGTM.
Tested in the following browsers:
@Nirzar: Now that the icon has been made smaller should we reduce the padding on the RHS accordingly?
@Nirzar: Now that the icon has been made smaller should we reduce the padding on the RHS accordingly?
YES! thank you. top right bottom should be the same space. you can adjust the padding accordingly.
Should that be in a follow on task? If so, @Nirzar, would you please sign off on this task and close resolved if appropriate?
@Nirzar: Gimme a number and I'll submit a patch. It's such a trivial change that creating a follow-on task for it seems frivolous and we run the risk of missing the next branch cut.
Sorry, read your comment after i created the subtask. i marked the subtask invalid.
here's the value
.search-overlay .clear {
right: 0.5em;
}Change 307052 had a related patch set uploaded (by Phuedx):
Search Overlay: Reduce clear icon's right gutter
Change 307052 merged by jenkins-bot:
Search Overlay: Reduce clear icon's right gutter
@dr0ptp4kt Can we resolve this? Otherwise it needs to be carried over to Reading-Web-Sprint-80-V-for-Vandalism