Page MenuHomePhabricator
Create Task
Maniphest T143296

Content translation fails in gerrit because of missing message vector-action-move
Closed, ResolvedPublic
Actions

Description

Started seeing this meesage in CI and causing CX patches failing in gerrit(example: https://integration.wikimedia.org/ci/job/mwext-testextension-php55/19466/console)

ResourcesTest::testMissingMessages
04:38:33 Message 'vector-action-move' required by 'ext.guidedTour.tour.cxpublish' must exist
04:38:33 Failed asserting that false is true.

May be related to the skin refactoring happened recently.

The following message from CX refers vector-action-move:

i18n/en.json
40:     "cx-publish-gt-first-step-description": "Click on the \"{{int:vector-action-move}}\" action under this menu to make the content available to all users as a regular page.",

The message is present in vector skin, but apparently the skin is not registered/loaded with the core while doing CI

Details

SubjectRepoBranchLines +/-
Copy from DOM instead of using vector-view-edit and vector-action-movemediawiki/extensions/ContentTranslationmaster+10 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

• santhosh created this task.Aug 18 2016, 4:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2016, 4:45 AM
• santhosh updated the task description. (Show Details)Aug 18 2016, 5:06 AM
• santhosh added a comment.Aug 18 2016, 5:08 AM

Refering a skin's message looks odd here, I think we should just use {{int:move}} from core messages

Legoktm subscribed.Aug 18 2016, 5:11 AM

You can also do something like rEGTO9bb4a4de1d45: Copy from DOM instead of using vector-view-edit.

gerritbot subscribed.Aug 18 2016, 5:28 AM

Change 305444 had a related patch set uploaded (by Santhosh):
Copy from DOM instead of using vector-view-edit and vector-action-move

https://gerrit.wikimedia.org/r/305444

gerritbot added a project: Patch-For-Review.Aug 18 2016, 5:28 AM
• santhosh claimed this task.Aug 18 2016, 5:58 AM
• santhosh triaged this task as Medium priority.
• santhosh added a parent task: T129976: Provide a structural unit test to confirm each module message exists.
Krinkle subscribed.Aug 19 2016, 10:06 PM
In T143296#2563339, @gerritbot wrote:

Change 305444 had a related patch set uploaded (by Santhosh):
Copy from DOM instead of using vector-view-edit and vector-action-move

https://gerrit.wikimedia.org/r/305444

May wanna use the approach of T143297 instead. Which is about the same message it seems.

• Mattflaschen-WMF renamed this task from Content translation fails in gerrit because of missing message vector-action-mov to Content translation fails in gerrit because of missing message vector-action-move.Aug 19 2016, 10:34 PM
• Mattflaschen-WMF subscribed.
In T143296#2568867, @Krinkle wrote:

May wanna use the approach of T143297 instead. Which is about the same message it seems.

That particular task is about VE messages in GuidedTour (same issue for GettingStarted).

Amire80 added a project: Essential-Work.Aug 21 2016, 10:57 AM
Amire80 moved this task from Needs Triage to CX10 (July-Sep. 2016) on the ContentTranslation board.Aug 21 2016, 11:09 AM
gerritbot added a comment.Aug 22 2016, 1:18 PM

Change 305444 merged by jenkins-bot:
Copy from DOM instead of using vector-view-edit and vector-action-move

https://gerrit.wikimedia.org/r/305444

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 22 2016, 2:00 PM
Amire80 closed this task as Resolved.Sep 13 2016, 12:16 PM
Amire80 added a project: Language-Q1-2016-17 Sprint 4.
Restricted Application added a project: Language-Engineering July-September 2016. · View Herald TranscriptSep 13 2016, 12:16 PM
Amire80 moved this task from Backlog to Done on the Language-Q1-2016-17 Sprint 4 board.Sep 13 2016, 12:16 PM
Amire80 edited projects, added ContentTranslation-Release10; removed Patch-For-Review.Sep 13 2016, 12:19 PM
Amire80 moved this task from Backlog to Infrastructure WMF requirements on the ContentTranslation-Release10 board.Sep 13 2016, 5:37 PM
Amire80 moved this task from Backlog to CX10 on the Language-Engineering July-September 2016 board.Oct 9 2016, 12:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL