Page MenuHomePhabricator

GuidedTour extension refers visualeditor-toolbar-savedialog message and causes CI failure
Closed, ResolvedPublic

Description

The following message require VE extension

"guidedtour-tour-firsteditve-save-description": "When you're ready, clicking \"{{int:visualeditor-toolbar-savedialog}}\" will make your changes visible for everyone."

and is causing CI failure now. See https://integration.wikimedia.org/ci/job/mwext-testextension-php55/19472/console

Event Timeline

Modules that are only used when another extension is installed should only be registered when that other extension is installed.

This is typically done by registering it conditionally from a hook instead of in extension.json.

Alternatively, if GuidedTour is intended to have a hard dependency on VisualEditor, update the CI job configuration to install VisualEditor alongside GuidedTour.

Change 305691 had a related patch set uploaded (by Mattflaschen):
Only register VE tour if VE is installed

https://gerrit.wikimedia.org/r/305691

Jdforrester-WMF closed this task as Resolved.Aug 19 2016, 9:32 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Change 305691 merged by jenkins-bot:
Only register VE tour if VE is installed

https://gerrit.wikimedia.org/r/305691

Mattflaschen-WMF reopened this task as Open.Aug 19 2016, 10:31 PM

Change 305746 had a related patch set uploaded (by Mattflaschen):
Only register VE-specific tour if VE is installed

https://gerrit.wikimedia.org/r/305746

Change 308121 had a related patch set uploaded (by Mattflaschen):
Allow passing a jQuery-wrapped node to attachTo

https://gerrit.wikimedia.org/r/308121

Change 308121 merged by jenkins-bot:
Allow passing a jQuery-wrapped node to attachTo

https://gerrit.wikimedia.org/r/308121

Change 305746 merged by jenkins-bot:
Message tweaks for VE and vector-view-edit

https://gerrit.wikimedia.org/r/305746

Jdforrester-WMF closed this task as Resolved.Sep 8 2016, 6:24 PM