Page MenuHomePhabricator
Create Task
Maniphest T143376

MediaWiki theme: Make disabled ToggleSwitchWidget follow visual logic of enabled state
Closed, ResolvedPublic
Actions

Description

Follow-up to T134795:
Disabled ToggleSwitchWidget should include same visual logic like enabled state: Outlined circle when switched off, filled circle when switched on.

Before (as of v0.17.8)After
T143376 ToggleSwitchWidget OOjs UI Demos 2016-08-18.png (193×289 px, 13 KB)
T143376 ToggleSwitchWidget disabled with patch OOjs UI Demos 2016-08-18.png (194×273 px, 12 KB)

Details

SubjectRepoBranchLines +/-
MediaWiki theme: Make ToggleSwitchWidget's disabled state follow enabledoojs/uimaster+20 -13
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Aug 19 2016, 1:19 AM
Restricted Application added a project: UI-Standardization. · View Herald TranscriptAug 19 2016, 1:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E updated the task description. (Show Details)Aug 19 2016, 1:25 AM
Volker_E updated the task description. (Show Details)
gerritbot subscribed.Aug 19 2016, 1:27 AM

Change 305605 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Make ToggleSwitchWidget's disabled state follow enabled

https://gerrit.wikimedia.org/r/305605

gerritbot added a project: Patch-For-Review.Aug 19 2016, 1:27 AM
Volker_E triaged this task as High priority.Aug 19 2016, 1:28 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.
gerritbot added a comment.Aug 19 2016, 4:11 PM

Change 305605 merged by jenkins-bot:
MediaWiki theme: Make ToggleSwitchWidget's disabled state follow enabled

https://gerrit.wikimedia.org/r/305605

Jdforrester-WMF closed this task as Resolved.Aug 19 2016, 4:18 PM
Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.17.9 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.9); removed OOUI.
Jdforrester-WMF removed a project: Patch-For-Review.
Volker_E moved this task from Backlog to Done on the UI-Standardization-Kanban board.Aug 22 2016, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL