Page MenuHomePhabricator

Citoid VisualEditor code failing to escape wiki markup for citoid derived citations in some situations
Open, LowPublic1 Estimate Story Points

Description

Sometimes titles (and possibly other fields) may contain '' or ''' in the source. In wiki context it means italics (2) or bold (3), so to preserve the original meaning VE should add <nowiki> (or html encoding).

Example for a page with '' in its title: http://www.themarker.com/wallstreet/1.3043194

An egregiously bad version of this reported here: https://www.mediawiki.org/w/index.php?title=Topic:U293el8scpngx7dy&topic_showPostId=u2a8s3c8njqmq358&fromnotif=1#flow-post-u2a8s3c8njqmq358

It does this...

Event Timeline

eranroz created this task.Aug 19 2016, 9:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2016, 9:37 PM

Not a job for Citoid, it's a job for consumers of Citoid's JSON (e.g. if the consumer is inserting into Markdown they have different concerns). Is the code "in" VE not doing that?

eranroz renamed this task from Citoid should escape wiki markup to VisualEditor should escape wiki markup for citoid derived citations.Aug 19 2016, 9:49 PM
eranroz updated the task description. (Show Details)
eranroz removed a project: Citoid.
Jdforrester-WMF renamed this task from VisualEditor should escape wiki markup for citoid derived citations to Citoid VisualEditor code failing to escape wiki markup for citoid derived citations in some situations.Aug 23 2016, 7:21 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a project: Citoid.
Jdforrester-WMF set the point value for this task to 1.
Mvolz moved this task from Backlog to Extension on the Citoid board.Sep 16 2016, 12:55 PM
Restricted Application added a subscriber: jeblad. · View Herald TranscriptNov 20 2017, 5:00 PM

You can see an example of the above bad data being imported into an article at https://en.wikipedia.org/w/index.php?title=Kelo_v._City_of_New_London&diff=prev&oldid=810668090

Mvolz raised the priority of this task from Medium to High.Dec 7 2017, 2:11 PM
Mvolz updated the task description. (Show Details)
Mvolz added a subscriber: Deskana.
Deskana lowered the priority of this task from High to Low.Aug 30 2018, 10:13 AM
Deskana moved this task from TR0: Interrupt to Freezer on the VisualEditor board.