Page MenuHomePhabricator
Create Task
Maniphest T143467

[Regression wmf.15] Starting editing in VE loads a new page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page for reading, open your browser console.
  2. Click the editing tab to start editing in VE.

Expected result:
The editor is loaded without reloading the page (just updating the URL).

Actual result:
The page is loaded with &veaction=edit. When you enable "Stop on all errors" in your debugger, you will stop on "ve.isUnmodifiedLeftClick is undefined".

This seems to be caused by rEVED87ea771ae68e: Centralize some checks for unmodified left clicks, the ve.utils.js file isn't loaded yet, so the used function isn't defined, causing an error and falling back to following the href of the link (which loads VE, but does so by loading a new page).

Details

SubjectRepoBranchLines +/-
init: port in isUnModifiedLeftClick without any VE core dependenciesmediawiki/extensions/VisualEditormaster+17 -3
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Aug 20 2016, 8:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2016, 8:06 AM
Florian subscribed.Aug 21 2016, 4:20 PM
Esanders subscribed.Aug 22 2016, 7:10 PM

Where are you seeing this? Not seeing it on en.wiki/betalabs/mw.org or local master.

DLynch added a comment.Aug 22 2016, 7:35 PM

I do see it. It's a dependency issue -- ext.visualEditor.desktopArticleTarget.init doesn't depend on ext.visualEditor.base, where ve.utils.js lives. I assume we don't want to just promote that file into an always-loaded dependency like ext.visualEditor.ve?

Quick fixes:

  • Move ve.utils.js into ext.visualEditor.ve
  • Move just that function into lib/ve/src/ve.js
  • Just copy that function into ve.init.mw.DesktopArticleTarget.init (course of least-change)
gerritbot subscribed.Aug 22 2016, 7:41 PM

Change 306044 had a related patch set uploaded (by DLynch):
init: port in isUnModifiedLeftClick without any VE core dependencies

https://gerrit.wikimedia.org/r/306044

gerritbot added a project: Patch-For-Review.Aug 22 2016, 7:41 PM
Jdforrester-WMF renamed this task from [Regression] Starting editing in VE loads a new page to [Regression wmf.15] Starting editing in VE loads a new page.Aug 22 2016, 9:23 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
gerritbot added a comment.Aug 23 2016, 12:01 AM

Change 306044 merged by jenkins-bot:
init: port in isUnModifiedLeftClick without any VE core dependencies

https://gerrit.wikimedia.org/r/306044

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 23 2016, 1:00 AM
matmarex merged a task: T143666: Clicking on VisualEditor's "edit" link causes "TypeError: ve.isUnmodifiedLeftClick is not a function".Aug 23 2016, 1:21 PM
matmarex added a subscriber: He7d3r.
Jdforrester-WMF closed this task as Resolved.Aug 23 2016, 6:07 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.Aug 23 2016, 6:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL