Page MenuHomePhabricator
Create Task
Maniphest T143514

Refreshed header drop down menus should use the semantic, <nav> element instead of <div> element
Closed, ResolvedPublic
Actions

Description

Well, simple really, they're navigation elements to help navigate around the wiki site! This should still be tested to make sure it still works.

Related Objects

Event Timeline

SamanthaNguyen created this task.Aug 21 2016, 11:26 AM
Restricted Application added a subscriber: MacFan4000. · View Herald TranscriptAug 21 2016, 11:26 AM
SamanthaNguyen moved this task from Backlog to Refreshed on the Brickimedia board.Aug 21 2016, 11:26 AM
SamanthaNguyen added a project: good first task.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 21 2016, 11:26 AM
SamanthaNguyen moved this task from Backlog to Feedback / Suggestions on the Refreshed board.Aug 21 2016, 11:27 AM
SamanthaNguyen moved this task from Feedback / Suggestions to Feedback on the Refreshed board.Sep 19 2016, 2:55 AM
SamanthaNguyen claimed this task.Jan 2 2017, 7:24 AM
Himanshuc3 subscribed.Jan 1 2018, 11:00 AM

Hi.
I am a beginner to Wikimedia.
Can you help me in getting started contributing to wikimedia with the help of this issue.

rosalieper added subscribers: Himanshu1495, rosalieper.Jan 22 2018, 8:40 AM

Hi @Himanshu1495 ,

Start by setting up Mediawiki locally. This is a tutorial for that .
If I am not mistaking, the bug is in the Skin extension. Clone the extension as well.
Then work on fixing the bug. In case of any problem you will have quicker replies on IRC. (#wikimedia-dev, #wikimedia-tech). But you can also leave them on the ticket.

Gopavasanth mentioned this in R1893:15cca539cd98: Change in tag <nav> instead tag <div> in Refreshed header dropdown menus.Feb 26 2018, 11:59 AM
gerritbot subscribed.Feb 26 2018, 5:14 PM

Change 414647 had a related patch set uploaded (by MacFan4000; owner: Gopavasanth):
[mediawiki/skins/Refreshed@master] Change in tag <nav> instead tag <div> in Refreshed header dropdown menus

https://gerrit.wikimedia.org/r/414647

gerritbot added a project: Patch-For-Review.Feb 26 2018, 5:14 PM
MacFan4000 mentioned this in R1893:4791461e8dac: Change in tag <nav> instead tag <div> in Refreshed header dropdown menus.Feb 26 2018, 5:16 PM
MacFan4000 reassigned this task from SamanthaNguyen to Gopavasanth.Feb 26 2018, 5:17 PM
Gopavasanth mentioned this in R1893:7b21d137b821: Change in tag <nav> instead tag <div> in Refreshed header dropdown menus.Mar 7 2018, 11:24 AM
Gopavasanth mentioned this in R1893:9b0ed52ae63c: Change in tag <nav> instead tag <div> in Refreshed header dropdown menus.
Gopavasanth added a comment.Mar 10 2018, 6:01 AM

@SamanthaNguyen could you please review my patch

Gopavasanth closed this task as Resolved.Apr 4 2018, 3:20 AM

According to patch https://gerrit.wikimedia.org/r/#/c/414647/

Aklapper removed a subscriber: Brickimedia.May 16 2023, 10:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits