As an iPhone 5c user who sometimes uses Find in Page in the Wikipedia for iOS beta app while in landscape mode, when a Find in Page search or up/down action identifies an on-page match, I would like to see that result in the (limited) viewport if technically possible, so that I have a quick context of the match without having to use the X close button.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
Testing criteria:
- Load the app on an iPhone 4s
- Load an article
- Rotate the device to landscape
- Tap find-in-page icon to search the article
- Ensure highlighted search terms can actually be seen onscreen (the space above the keyboard on iPhone 4s is small)
- See the PR here for animations.
Comment Actions
Unfortunately I don't have a 4s testing device, but the gifs presented in the comment above look good.
Comment Actions
Tested on an iPhone 7+ with iOS 10.3 and an iPhone 5s with iOS 10.2 on Beta App 5.5.0 (1138)
Works fine on the iPhone 7+.
On the iPhone 5s, which is rather small, I noticed that when searching for very common words the results tend to appear below the keyboard once the user has scrolled (using the arrows) for a while.
Example:
- Loaded the article for Apatosaurus
- Placed the device in landscape mode
- Searched-on-page for the word "age"
- After 4 to 5 taps on the down arrow, the results appear below the keyboard.
@Mhurd Let me know if I should move this one on the workboard. I also do not have an iPhone 4. The smallest I have is an iPhone 5s. I can see if TSG has any.
Comment Actions
Hello, I also do not have any iPhone 4's. I left Andy a message asking if he can help me to get any later - today he had another commitment.
Comment Actions
Andy got back to me. TSG returned the iPhone 4s about a year ago to Wikimedia so we don't have any testable device.
Comment Actions
Tested on iPhone 7+ with iOS 10.3.2, iPhone 5s with iOS 10.2, and iPad Mini 2 Retina on 10.2.1 on App version 5.5.0 (1149)
Fixed!