Page MenuHomePhabricator

Deletion summary lengths problems
Open, LowPublic

Description

These are in fact two different bugs on the same code:
a) Deletion summary was prefilled with up to 150 characters from the page content, leaving space for the sysop to add his reason. r27170 changed it to the maximun available (allowed by the language), eating that content. Rationale was "In the deletion default reasons, calculate how much text to get from the article text, rather than getting 150 characters (which may be too much)". I don't know why max(150, $maxLength) wasn't used. (Regression was complained onm ML).

b) With r27832 (T11633: Add a predefined list of delete reasons to the deletion form) the calculated length isn't accurate any more. The delete reason from the list is prepended and mysql trims the reason field (see URL). Either change the <input maxlength to 255 - max(strlen(deletereasons)) or perform some black magic with javascript when changing the combo value (hard to get right).


Version: 1.12.x
Severity: trivial
URL: http://es.wikipedia.org/w/index.php?title=Especial%3ALog&type=delete&user=&page=Usuario%3APlatonides%2FCantares+de+Dzitbalch%C3%A9

Details

Reference
bz12359

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:57 PM
bzimport set Reference to bz12359.
bzimport added a subscriber: Unknown Object (MLST).

herd wrote:

b) With r27832 (bug 9633) the calculated length isn't accurate any more.

Selecting from the dropdown of reasons should probably override (and if JS is avaiable, blank) the 'reason' field.

mike.lifeguard+bugs wrote:

(In reply to comment #1)

b) With r27832 (bug 9633) the calculated length isn't accurate any more.

Selecting from the dropdown of reasons should probably override (and if JS is
avaiable, blank) the 'reason' field.

No, using both is a common use case.