Page MenuHomePhabricator

Code-Review permission for @Abhinand in MediaWiki/extensions/EditNotify
Closed, ResolvedPublic

Description

Request for +2 Code-Review permission for @Abhinand in MediaWiki extension EditNotify [ https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/EditNotify ].
As I am not able to get the patch merged- [ https://gerrit.wikimedia.org/r/#/c/305974/ ]

Event Timeline

Abhinand created this task.Aug 23 2016, 6:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2016, 6:17 AM
Abhinand renamed this task from Permission for Code-Review in extension EditNotify to Code-Review permission for @Abhinand in MediaWiki/extensions/EditNotify.Aug 23 2016, 6:36 AM
Abhinand updated the task description. (Show Details)

The project already has an owner group:
extension-EditNotify
https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/EditNotify,access

where the user @Abhinand is already a member of:
https://gerrit.wikimedia.org/r/#/admin/groups/1235,members

So, you should already have access to merge the change (with Code-Review +2).

Thanks @Florian . I was trying to add myself as reviewer which I couldn't . Got it merged. Thanks once again.

Florian closed this task as Invalid.Aug 23 2016, 11:32 AM

You don't need to add you as a reviewer (you even can't do that).

demon changed the task status from Invalid to Resolved.Aug 23 2016, 2:19 PM
demon added a subscriber: demon.

@Abhinand has ownership and submit rights here, should be fine going forward.

Yeah, thanks @demon :)