Page MenuHomePhabricator
Create Task
Maniphest T143692

Scap::server::sources is out of sync with the repositories actually present on tin/mira
Closed, ResolvedPublic
Actions

Description

So, here is a quick list of projects that use scap3, with the following info:

  • whether they're set up via scap::server::sources
  • what the actual clone url is on tin
  • what the clone url would be according to scap::server::sources
projectscap-declaredactual originpuppet-generated origin
analytics/refineryYhttps://gerrit.wikimedia.org/r/analytics/refinery/.githttps://gerrit.wikimedia.org/r/p/analytics/refinery.git
changeprop/deployNhttps://gerrit.wikimedia.org/r/mediawiki/services/change-propagation/deploy/.githttps://gerrit.wikimedia.org/r/p/mediawiki/services/change-propagation/deploy.git
citoid/deployNhttps://gerrit.wikimedia.org/r/mediawiki/services/citoid/deployhttps://gerrit.wikimedia.org/r/p/mediawiki/services/citoid/deploy.git
cxserver/deployYhttps://gerrit.wikimedia.org/r/mediawiki/services/cxserver/deploy/.githttps://gerrit.wikimedia.org/r/p/cxserver/deploy.git
dumps/dumpsYhttps://gerrit.wikimedia.org/r/operations/dumps/.githttps://gerrit.wikimedia.org/r/p/operations/dumps.git
eventlogging/analyticsYhttps://gerrit.wikimedia.org/r/p/eventlogging.githttps://gerrit.wikimedia.org/r/p/eventlogging.git
eventlogging/eventbusYhttps://gerrit.wikimedia.org/r/eventlogging/.githttps://gerrit.wikimedia.org/r/p/eventlogging.git
graphoid/deployYhttps://gerrit.wikimedia.org/r/mediawiki/services/graphoid/deploy/.githttps://gerrit.wikimedia.org/r/p/graphoid/deploy.git
kartotherian/deployYhttps://gerrit.wikimedia.org/r/maps/kartotherian/deploy/.githttps://gerrit.wikimedia.org/r/p/kartotherian/deploy.git
mathoid/deployNhttps://gerrit.wikimedia.org/r/mediawiki/services/mathoid/deploy/.githttps://gerrit.wikimedia.org/r/p/mediawiki/services/mathoid/deploy.git
mobileapps/deployYhttps://gerrit.wikimedia.org/r/mediawiki/services/mobileapps/deploy/.githttps://gerrit.wikimedia.org/r/p/mobileapps/deploy.git
ores/deployYhttps://gerrit.wikimedia.org/r/p/mediawiki/services/ores/deploy.githttps://gerrit.wikimedia.org/r/p/mediawiki/services/ores/deploy.git
parsoid/deployYhttps://gerrit.wikimedia.org/r/p/mediawiki/services/parsoid/deploy/.githttps://gerrit.wikimedia.org/r/p/parsoid/deploy.git
phabricator/deploymentYhttps://gerrit.wikimedia.org/r/p/phabricator/deploymenthttps://gerrit.wikimedia.org/r/p/phabricator/deployment.git
servermon/servermonNhttps://github.com/servermon/servermon.githttps://gerrit.wikimedia.org/r/p/servermon/servermon.git
tilerator/deployYhttps://gerrit.wikimedia.org/r/maps/tilerator/deploy/.githttps://gerrit.wikimedia.org/r/p/tilerator/deploy.git
wdqs/wdqsYhttps://gerrit.wikimedia.org/r/wikidata/query/deploy/.githttps://gerrit.wikimedia.org/r/p/wikidata/query/deploy.git
zotero/translation-serverNhttps://gerrit.wikimedia.org/r/mediawiki/services/zotero/translation-server/.githttps://gerrit.wikimedia.org/r/p/mediawiki/services/zotero/translation-server.git
zotero/translatorsNhttps://gerrit.wikimedia.org/r/mediawiki/services/zotero/translators/.githttps://gerrit.wikimedia.org/r/p/mediawiki/services/zotero/translators.git

So we have 2 out of 19 projects (the ones marked in bold) managed with scap3 that are set up correctly, so about 10%. We're on a roll!

We should really fix this, scap::source and what's happening on tin/mira.

Also, we should remove all entries for these projects from repo_config, that is for trebuchet and uses a weird sync system (not via puppet, but via salt and an exec from puppet, yuck).

Details

SubjectRepoBranchLines +/-
scap_source: enforce the origin urloperations/puppetproduction+30 -6
role::deployment::server: fix scap3/trebuchet declarationsoperations/puppetproduction+34 -61
Customize query in gerrit

Related Objects

Event Timeline

Joe created this task.Aug 23 2016, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2016, 4:20 PM
Joe triaged this task as High priority.Aug 23 2016, 4:20 PM
Joe updated the task description. (Show Details)
• mobrovac added projects: Scap, User-mobrovac.Aug 23 2016, 4:31 PM
thcipriani subscribed.Aug 23 2016, 4:36 PM
• demon subscribed.Aug 23 2016, 4:43 PM
Joe claimed this task.Aug 24 2016, 9:56 AM
gerritbot subscribed.Aug 24 2016, 2:17 PM

Change 306440 had a related patch set uploaded (by Giuseppe Lavagetto):
role::deployment::server: fix scap3/trebuchet declarations

https://gerrit.wikimedia.org/r/306440

gerritbot added a project: Patch-For-Review.Aug 24 2016, 2:17 PM
Joe mentioned this in rOPUPf8de69dfa349: role::deployment::server: fix scap3/trebuchet declarations.Aug 24 2016, 2:23 PM
gerritbot added a comment.Oct 4 2016, 8:51 AM

Change 306440 merged by Giuseppe Lavagetto:
role::deployment::server: fix scap3/trebuchet declarations

https://gerrit.wikimedia.org/r/306440

Joe added a comment.Oct 5 2016, 7:55 AM

This is mostly done; next step would be to make scap_source verify the origin and change it when running.

Joe added a project: User-Joe.Oct 5 2016, 8:00 AM
Joe moved this task from Backlog to Doing on the User-Joe board.Oct 5 2016, 8:50 AM
gerritbot added a comment.Oct 5 2016, 4:45 PM

Change 314296 had a related patch set uploaded (by Giuseppe Lavagetto):
scap_source: enforce the origin url

https://gerrit.wikimedia.org/r/314296

gerritbot added a comment.Oct 6 2016, 8:07 AM

Change 314296 merged by Giuseppe Lavagetto:
scap_source: enforce the origin url

https://gerrit.wikimedia.org/r/314296

Joe added a comment.Oct 6 2016, 11:52 AM

So, apart from servermon, which points to a (still) inexistent url, all other services that use scap now have the correct repository url enforced by scap_source and such a problem will not be replicated.

Joe closed this task as Resolved.Oct 6 2016, 11:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL