info wrote:

switch on right variable, also remove unneeded case and addError (review!)

I don't trust Eclipse Create patch on Windows, here's the patch.

Note the last change: should SMW be aggressive on bad units or flexible?

Index: C:/xampplite/htdocs/mediawiki/extensions/SemanticMediaWiki/includes/SMW_DV_Temperature.php

• C:/xampplite/htdocs/mediawiki/extensions/SemanticMediaWiki/includes/SMW_DV_Temperature.php (revision 28741)

+++ C:/xampplite/htdocs/mediawiki/extensions/SemanticMediaWiki/includes/SMW_DV_Temperature.php (working copy)
@@ -27,7 +27,7 @@

		// Find current ID and covert main values to Kelvin, if possible
		// Note: there is no error when unknown units are used.
		$this->m_unitin = $this->getUnitID($this->m_unit);

• switch ( $this->m_unit ) {

+ switch ( $this->m_unitin ) {

			case 'K':
				$this->m_unit = 'K';
			break;

@@ -35,7 +35,7 @@

				$this->m_unit = 'K';
				$this->m_value = $this->m_value + 273.15;
			break;

• case '°F': case 'Fahrenheit':

+ case '°F':

				$this->m_unit = 'K';
				$this->m_value = ($this->m_value - 32) /1.8 + 273.15;
			break;

@@ -40,6 +40,10 @@

				$this->m_value = ($this->m_value - 32) /1.8 + 273.15;
			break;
			default: //unsupported unit

+ TODO: Should this be an error? Without addError(), SMW displays
+ and stores your temperature, but doesn't convert it.
+ // Maybe have an addWarning()?
+ $this->addError(wfMsgForContent('smw_unsupportedunit',$this->m_unit));

				$this->m_unit = $this->m_unitin;
			break;
		}

Attached:

OK, I applied that patch manually. I agree that an error message is appropriate for unsupported units here, since unsupported temperature units should be due to typos in almost any case where type:temperature would be used.