Page MenuHomePhabricator

Empty notification panel when there is only one big local bundle
Closed, ResolvedPublic

Description

If a user has a big local bundle (26 new topics on Page A), the panel opens empty (the api returns 0 results).

Details

Related Gerrit Patches:

Event Timeline

SBisson created this task.Aug 24 2016, 6:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2016, 6:37 PM

Change 306481 had a related patch set uploaded (by Sbisson):
Get the overfetched before bundling to avoid removing the base

https://gerrit.wikimedia.org/r/306481

Change 306481 merged by jenkins-bot:
Get the overfetched before bundling to avoid removing the base

https://gerrit.wikimedia.org/r/306481

Checked in betalabs - the bundle of 26 notificaitons is displayed in the flyout.

The expanded flyout - the titles are displayed correctly: for testing purposes they are short.

Change 306481 merged by jenkins-bot:
Get the overfetched before bundling to avoid removing the base
https://gerrit.wikimedia.org/r/306481

Reverted in https://gerrit.wikimedia.org/r/#/c/306835/ because it broke pagination beyond 51 notifications on the special page.

Change 306901 had a related patch set uploaded (by Sbisson):
Loading notifications starting with one big local bundle

https://gerrit.wikimedia.org/r/306901

Change 306901 merged by jenkins-bot:
Loading notifications starting with one big local bundle

https://gerrit.wikimedia.org/r/306901

Re-checked in betalabs - pagination does not break when there is a big bundle (>25).

jmatazzoni closed this task as Resolved.Oct 11 2016, 12:24 AM