Page MenuHomePhabricator
Create Task
Maniphest T143829

Remove unnecessary "Read in another language" button except for on Main pages
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
• JKatzWMF
Aug 24 2016, 8:14 PM
Tags
Referenced Files
F4634818: T143829 iOS 9.3.2 in Safari.PNG
Oct 20 2016, 8:42 PM
F4634815: T143829 iOS 9.3.2 in Chrome.PNG
Oct 20 2016, 8:42 PM
F4634816: T143829 Android 4.4.2 in Android Chrome.png
Oct 20 2016, 8:42 PM
F4634817: T143829 Android 4.4.2 in Android Browser.png
Oct 20 2016, 8:42 PM
F4632986: Screen Shot 2016-10-20 at 11.11.53.png
Oct 20 2016, 10:14 AM
F4623361: pasted_file
Oct 18 2016, 8:31 PM
F4623198: Screen Shot 2016-10-18 at 9.36.14 PM.png
Oct 18 2016, 7:38 PM
Subscribers
Aklapper
Dalba
dr0ptp4kt
gerritbot
Jdlrobson
• jhobs
• JKatzWMF
View All 14 Subscribers
Tokens
"Party Time" token, awarded by Nirzar.

Description

Story
As a user, I don't need two language buttons, as it is duplicate functionality

Background
Remove bottom "read in another language" button which we left in place initially to direct existing users to the new language switching button. Currently redirects to thew new button. Side note: we should probably do this before removing instrumentation (T130849) in case this was still driving a high % of clicks.

Test Plan

  1. Visit http://reading-web-staging.wmflabs.org/wiki/T143829 with a modern or basic browser, e.g. Safari 9 on an iPhone 6.
  2. Scroll to the bottom of the article
  3. Observe that there's no "Read in another language" button
  4. Scroll to the top of the article
  5. Tap the Screen Shot 2016-10-20 at 11.11.53.png (28×34 px, 1 KB) button
  6. Observe that the language overlay opens with a link to the page on another wiki

Details

SubjectRepoBranchLines +/-
Remove MinervaBottomLanguageButtonmediawiki/extensions/MobileFrontendmaster+4 -80
Update wgMinervaBottomLanguageButton default valuemediawiki/extensions/MobileFrontendmaster+1 -16
Disable bottom language button in Minervaoperations/mediawiki-configmaster+3 -0
Fix logic of MinervaBottomLanguageButtonmediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.21+4 -2
Fix logic of MinervaBottomLanguageButtonmediawiki/extensions/MobileFrontendwmf/1.28.0-wmf.22+4 -2
Fix logic of MinervaBottomLanguageButtonmediawiki/extensions/MobileFrontendmaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JKatzWMF created this task.Aug 24 2016, 8:14 PM
• JKatzWMF mentioned this in T137932: [EPIC] Mobile language switching improvement work II.
MBinder_WMF unsubscribed.Aug 25 2016, 6:19 PM
dr0ptp4kt renamed this task from Remove bottom button to Remove unnecessary "Read in another language" button except for on Main pages.Aug 25 2016, 8:28 PM
dr0ptp4kt edited projects, added MobileFrontend; removed Epic.
dr0ptp4kt moved this task from Incoming to Product Owner Backlog on the Web-Team-Backlog board.
dr0ptp4kt subscribed.Aug 25 2016, 8:31 PM

I believe originally we thought we should have about 6 weeks of the new page action bar before removing this.

Dalba merged a task: T143950: "Read in another language" in mobile view should directly point to the target page.Aug 25 2016, 10:53 PM
Dalba subscribed.
ovasileva moved this task from Product Owner Backlog to Upcoming on the Web-Team-Backlog board.Sep 28 2016, 2:01 PM
ovasileva updated the task description. (Show Details)Sep 28 2016, 6:13 PM
ovasileva updated the task description. (Show Details)
• Nirzar awarded a token.Sep 28 2016, 7:13 PM
ovasileva added a project: Reading-Web-Sprint-83-Y?.Oct 3 2016, 4:13 PM
MBinder_WMF set the point value for this task to 3.Oct 3 2016, 4:22 PM
ovasileva mentioned this in T130849: Clean up language button related code on mobile web (instrumentation + old feature flagged code).Oct 11 2016, 3:17 PM
MBinder_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-83-Y? board.Oct 11 2016, 5:02 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-83-Y? board.Oct 11 2016, 5:08 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Oct 11 2016, 5:18 PM
Jdlrobson claimed this task.Oct 11 2016, 5:34 PM
gerritbot subscribed.Oct 11 2016, 5:44 PM

Change 315314 had a related patch set uploaded (by Jdlrobson):
Disable bottom language button in Minerva

https://gerrit.wikimedia.org/r/315314

gerritbot added a project: Patch-For-Review.Oct 11 2016, 5:44 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-83-Y? board.Oct 11 2016, 5:52 PM
Jdlrobson moved this task from Code Review to Doing on the Reading-Web-Sprint-83-Y? board.Oct 11 2016, 5:55 PM
gerritbot added a comment.Oct 11 2016, 6:06 PM

Change 315318 had a related patch set uploaded (by Jdlrobson):
Remove MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315318

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-83-Y? board.Oct 11 2016, 6:07 PM
gerritbot added a comment.Oct 11 2016, 8:59 PM

Change 315414 had a related patch set uploaded (by Jdlrobson):
Fix logic of MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315414

gerritbot added a comment.Oct 11 2016, 9:13 PM

Change 315414 merged by jenkins-bot:
Fix logic of MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315414

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Oct 11 2016, 10:00 PM
gerritbot added a comment.Oct 11 2016, 11:05 PM

Change 315446 had a related patch set uploaded (by EBernhardson):
Fix logic of MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315446

gerritbot added a comment.Oct 11 2016, 11:07 PM

Change 315447 had a related patch set uploaded (by EBernhardson):
Fix logic of MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315447

gerritbot added a comment.Oct 11 2016, 11:15 PM

Change 315446 merged by jenkins-bot:
Fix logic of MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315446

gerritbot added a comment.Oct 11 2016, 11:16 PM

Change 315447 merged by jenkins-bot:
Fix logic of MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315447

Stashbot subscribed.Oct 11 2016, 11:22 PM

Mentioned in SAL (#wikimedia-operations) [2016-10-11T23:21:58Z] <ebernhardson@mira> Synchronized php-1.28.0-wmf.22/extensions/MobileFrontend/includes/skins/SkinMinerva.php: SWAT: Fix logic of MinervaBottomLanguageButton T143829 (duration: 00m 50s)

Stashbot added a comment.Oct 11 2016, 11:23 PM

Mentioned in SAL (#wikimedia-operations) [2016-10-11T23:23:12Z] <ebernhardson@mira> Synchronized php-1.28.0-wmf.21/extensions/MobileFrontend/includes/skins/SkinMinerva.php: SWAT: Fix logic of MinervaBottomLanguageButton T143829 (duration: 00m 50s)

gerritbot added a comment.Oct 11 2016, 11:24 PM

Change 315314 merged by jenkins-bot:
Disable bottom language button in Minerva

https://gerrit.wikimedia.org/r/315314

Stashbot added a comment.Oct 11 2016, 11:30 PM

Mentioned in SAL (#wikimedia-operations) [2016-10-11T23:30:35Z] <ebernhardson@mira> Synchronized wmf-config/InitialiseSettings.php: SWAT T143829 Disable bottom language button in Minerva (duration: 00m 50s)

Jdlrobson added a subscriber: • Tbayer.Oct 11 2016, 11:32 PM

@Tbayer @ovasileva @JKatzWMF the language button has now been dropped from the bottom of the page. Please keep a close eye on interactions to the language switcher over the next week. If you see anything that suggests people are interacting less with the language switcher please report them before next Tuesday (18th) at which point I will continue the process of removing the code that allows us to have the language switcher at the bottom of the page and the language switcher instrumentation code. Up until that time it is trivial for us to revert this if necessary.

(We should be wary that now we don't have a button that says "change language" we are testing the strength of the language icon as well as whether people are more likely to switch language after reading an article in full)

Jdlrobson reassigned this task from Jdlrobson to ovasileva.Oct 11 2016, 11:33 PM
Jdlrobson subscribed.

Devs: Please review so we are ready to go if necessary, but Olga I'm assigning this to you to be clear that you are responsible for giving us the green light to remove this code.

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 12 2016, 12:00 AM
ovasileva added a comment.Oct 12 2016, 9:05 AM

@Jdlrobson - sounds good. Will comment before the 18th if any issues arise.

gerritbot added a comment.Oct 13 2016, 12:39 PM

Change 315668 had a related patch set uploaded (by Phuedx):
Update wgMinervaBottomLanguageButton default value

https://gerrit.wikimedia.org/r/315668

gerritbot added a comment.Oct 13 2016, 5:06 PM

Change 315668 merged by jenkins-bot:
Update wgMinervaBottomLanguageButton default value

https://gerrit.wikimedia.org/r/315668

Jdlrobson moved this task from Code Review to Needs Analysis on the Reading-Web-Sprint-83-Y? board.Oct 13 2016, 7:26 PM

Moved to needs analysis since the work has had a good deal of review and we are waiting on the green light from @ovasileva

phuedx added subscribers: • jhobs, phuedx.Oct 14 2016, 9:44 AM

@jhobs, @Jdlrobson; I don't tend to track code review comments on merged patches so I'll respond here:

In https://gerrit.wikimedia.org/r/#/c/315668/1/tests/browser/features/step_definitions/language_steps.rb, I removed the "When I click the language button" step because it wasn't being used anywhere. I should've noted that in the commit message.

• jhobs added a comment.Oct 14 2016, 4:27 PM
In T143829#2715728, @phuedx wrote:

@jhobs, @Jdlrobson; I don't tend to track code review comments on merged patches so I'll respond here:

In https://gerrit.wikimedia.org/r/#/c/315668/1/tests/browser/features/step_definitions/language_steps.rb, I removed the "When I click the language button" step because it wasn't being used anywhere. I should've noted that in the commit message.

Thanks for following up @phuedx .

Jdlrobson added a comment.Oct 17 2016, 5:40 PM

@ovasileva hopefully there should be enough data to give a gut feel for a decision now. Can you take a look Tuesday/Wednesday?

ovasileva added a comment.Oct 17 2016, 5:51 PM

@Jdlrobson - yup! hoping to look at it tonight/tomorrow AM and give an update

ovasileva added a comment.Oct 18 2016, 7:38 PM

Ok, so we're seeing a small decrease after the change, but not significant. However, there's a strange drop in use between september 9 and september 21. Any idea where this came from?

Screen Shot 2016-10-18 at 9.36.14 PM.png (359×491 px, 35 KB)

• Nirzar added a comment.Oct 18 2016, 8:31 PM

@ovasileva this might be related but there is a big drop in search events between sep 9 and sep 21... maybe an eventloggin bug?

pasted_file (347×999 px, 99 KB)

• Tbayer added a comment.Oct 18 2016, 8:50 PM

Indeed, these dates look very similar to T146840 .

• Tbayer mentioned this in T146840: Various EventLogging schemas losing events since around September 8/9.Oct 18 2016, 8:55 PM
ovasileva added a comment.Oct 19 2016, 10:11 AM

Ok, seems to be an eventlogging issue. Ok, @Jdlrobson we're ready for this.

ovasileva removed ovasileva as the assignee of this task.Oct 19 2016, 10:12 AM
ovasileva moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-83-Y? board.
Jdlrobson moved this task from To Do to Code Review on the Reading-Web-Sprint-83-Y? board.Oct 19 2016, 4:57 PM
gerritbot added a comment.Oct 20 2016, 9:45 AM

Change 315318 merged by jenkins-bot:
Remove MinervaBottomLanguageButton

https://gerrit.wikimedia.org/r/315318

phuedx moved this task from Code Review to Needs QA on the Reading-Web-Sprint-83-Y? board.Oct 20 2016, 9:52 AM
phuedx assigned this task to Jdlrobson.Oct 20 2016, 10:14 AM
phuedx updated the task description. (Show Details)
phuedx added a subscriber: Nicholas.tsg.

Ping @Nicholas.tsg.

Nicholas.tsg added a comment.Oct 20 2016, 8:42 PM

Attached are screencaps of the different environments I tested with which were listed in the Compatibility page: Safari and Chrome for iOS, and Android Browser and Chrome for Android. In all instances tapping "Qafár af" in the language overlay opened a link to a page on another wiki, so this looks like it works as expected.

T143829 iOS 9.3.2 in Safari.PNG (2×1 px, 183 KB)

T143829 Android 4.4.2 in Android Browser.png (1×720 px, 108 KB)

T143829 Android 4.4.2 in Android Chrome.png (1×720 px, 111 KB)

T143829 iOS 9.3.2 in Chrome.PNG (2×1 px, 156 KB)

Nicholas.tsg moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-83-Y? board.Oct 20 2016, 8:43 PM
ovasileva closed this task as Resolved.Oct 21 2016, 9:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL