tux doesn't let the user know about it if the language is a non-translatable language
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Glaisher
	Aug 25 2016, 5:45 AM

Description

See for example: https://translatewiki.net/wiki/Special:Translate?group=out-fuel-desktop&language=hi&filter=&action=translate It shows an empty interface to the user. This isn't a very user-friendly behavior. Instead, it should tell the user about it through an error message. Non-TUX shows "Translation to this language is disabled".

Details

	Subject	Repo	Branch	Lines +/-
	Move language validation from Special:Translate to ApiQueryMessageCollection	mediawiki/extensions/Translate	master	+91 -175

Customize query in gerrit

Related Objects

Mentioned In: T190128: Changing settings on Special:Translate produces "Uncaught TypeError: Cannot read property 'changeSettings' of null"

Event Timeline

Glaisher created this task.Aug 25 2016, 5:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2016, 5:45 AM

Glaisher moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Aug 25 2016, 5:50 AM

Nikerabbit mentioned this in T190128: Changing settings on Special:Translate produces "Uncaught TypeError: Cannot read property 'changeSettings' of null".Mar 20 2018, 10:43 AM

Change 424607 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Move language validation from Special:Translate to ApiQueryMessageCollection

https://gerrit.wikimedia.org/r/424607

gerritbot added a project: Patch-For-Review.Apr 6 2018, 2:44 PM

Pginer-WMF triaged this task as High priority.May 15 2018, 7:56 AM

Pginer-WMF added a project: Language-2018-Apr-June.

Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-2018-Apr-June board.

• Petar.petkovic moved this task from Maintenance backlog to In Review on the Language-2018-Apr-June board.May 22 2018, 4:40 PM

Nikerabbit claimed this task.May 23 2018, 7:01 AM

Change 424607 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Move language validation from Special:Translate to ApiQueryMessageCollection

https://gerrit.wikimedia.org/r/424607

• Petar.petkovic removed a project: Patch-For-Review.Jun 5 2018, 7:13 PM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.

@Nikerabbit the url in the ticket redirects to the page with the error message about non-existing message group.

So far, I haven't seen the error messages from the patch:

"apierror-translate-language-disabled": "Translation to $1 is disabled.",
"apierror-translate-language-disabled-reason": "Translation to $1 is disabled: $2",
"apierror-translate-language-disabled-source": "The source language of this group is $1. Please select another language to translate into."

It seems that these error messages will appear if I can select a valid lang from the list of available languages but it would be disabled? Checking for Special:Translate?group=ext-wikitextloggedinout&language=tlh&filter=&action=translate (https://translatewiki.net/wiki/Portal:Tlh) for the valid message group displays an empty page without any error messages:

Screen Shot 2018-06-05 at 3.06.15 PM.png (321×1 px, 73 KB)

@Etonkovidova The patch was merged late my time yesterday, so I had not deployed it yet. Sorry about that, I am doing it now. The patch also fixes other tasks, which I am adding to the QA column (we only added one to not clog up the to-review board).

Other test URLs:

Thanks, @Nikerabbit.
https://translatewiki.net/w/i.php?title=Special:Translate&group=ajapaik-app&language=hif&filter=%21translated&action=translate
displays

But strangely, https://translatewiki.net/w/i.php?title=Special:Translate&group=ajapaik-playstore&language=hif&filter=%21translated&action=translate will display
$1 is displayed instead of the language name - is it expected?

I thought that it could be because of the dash in the Group name, but there are many of such group names, e.g. https://translatewiki.net/w/i.php?title=Special:Translate&group=tsint-commonshelper2&language=hif&filter=%21translated&action=translate. I tried few of such names and all seem to be fine.

I am closing the task as Resolve since the reported issues has been fixed.

• Petar.petkovic moved this task from QA to Done on the Language-2018-Apr-June board.Jun 6 2018, 6:45 PM

	F18843795: Screen Shot 2018-06-06 at 11.06.09 AM.png
	Jun 6 2018, 6:23 PM

	F18843874: Screen Shot 2018-06-06 at 11.16.38 AM.png
	Jun 6 2018, 6:23 PM

	F18823830: Screen Shot 2018-06-05 at 2.41.13 PM.png
	Jun 5 2018, 10:07 PM

	F18824404: Screen Shot 2018-06-05 at 3.06.15 PM.png
	Jun 5 2018, 10:07 PM

tux doesn't let the user know about it if the language is a non-translatable languageClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

tux doesn't let the user know about it if the language is a non-translatable language
Closed, ResolvedPublic
Actions