Delete from the pending database when a transaction is failed or completed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	awight
	Aug 25 2016, 10:16 PM

Referenced Files

None

Subscribers

Description

This is tricky... When the donor returns from an Ingenico iframe and we fail them for e.g. bad CVV, we need to delete the message from our pending database to prevent orphan rectification and stuff.

But we don't have a way to do that, and it would be a shame to resurrect the "antimessage" antipattern.

Details

Subject	Repo	Branch	Lines +/-
Use ct_id to find completed, avoid race	wikimedia/fundraising/SmashPig	master	+266 -7
Check payments_init for 'failed' in pending QC	wikimedia/fundraising/SmashPig	master	+11 -35
Fix status label	wikimedia/fundraising/crm	deployment	+2 -1
Fix status label	wikimedia/fundraising/crm	master	+2 -1
Fix "complete" status label	wikimedia/fundraising/SmashPig	master	+9 -5
Don't store payments record if the transaction is finalized	wikimedia/fundraising/SmashPig	master	+384 -3
Delete from pending db once the transaction is completed	wikimedia/fundraising/crm	master	+5 -0
Use DeletePendingJob in frontend	mediawiki/extensions/DonationInterface	master	+23 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T117466 Q3 GOALS! (January-March) Keep at top of Q3 column
Resolved	None	T108229 [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack
Resolved	None	T133108 [Epic] Rewrite all queue clients to use a single shim library, improve library
Resolved	awight	T133754 Upstream whatever we can to PHP-Queue
Resolved	awight	T133190 Remove KeyValueStore from PHP-Queue
Open	None	T134191 Write CiviCRM extension to view pending db records
Resolved	None	T130897 [Epic] Consolidate "pending" queue usages
Resolved	awight	T131275 [Epic] Move orphan rectifier out of payments
Resolved	awight	T141486 Rewrite orphan rectifier to use the pending database and WmfFramework
Resolved	Ejegg	T143945 Delete from the pending database when a transaction is failed or completed
Resolved	awight	T144562 PayPal's payments-init messages are inaccurate

Event Timeline

awight created this task.Aug 25 2016, 10:16 PM

Maybe the payments-init queue consumer?

Nice reuse!

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Pretending This Isn't Happening board.Aug 26 2016, 8:24 PM

Change 306840 had a related patch set uploaded (by Ejegg):
Use DeletePendingJob in frontend

https://gerrit.wikimedia.org/r/306840

gerritbot added a project: Patch-For-Review.Aug 26 2016, 8:26 PM

Ejegg moved this task from Doing to Review on the Fundraising Sprint Pretending This Isn't Happening board.Aug 26 2016, 8:35 PM

• DStrine moved this task from Triage to Current Sprint & Completed in Q1 1617 on the Fundraising-Backlog board.Aug 29 2016, 7:49 PM

awight moved this task from Review to Doing on the Fundraising Sprint Pretending This Isn't Happening board.Aug 31 2016, 10:37 PM

• DStrine added a project: Fundraising Sprint Qwerty Thwacking.Aug 31 2016, 11:10 PM

Change 306840 abandoned by Ejegg:
Use DeletePendingJob in frontend

Reason:
will handle this in init queue consumer

https://gerrit.wikimedia.org/r/306840

Change 308788 had a related patch set uploaded (by Awight):
[WIP] Don't store payments record if the transaction is finalized

https://gerrit.wikimedia.org/r/308788

awight moved this task from Backlog to Doing on the Fundraising Sprint Qwerty Thwacking board.Sep 6 2016, 6:29 PM

awight added a subtask: T144562: PayPal's payments-init messages are inaccurate.Sep 6 2016, 8:22 PM

Change 308898 had a related patch set uploaded (by Awight):
Delete from pending db once the transaction is completed

https://gerrit.wikimedia.org/r/308898

awight moved this task from Doing to Review on the Fundraising Sprint Qwerty Thwacking board.Sep 6 2016, 10:57 PM

Change 308898 merged by jenkins-bot:
Delete from pending db once the transaction is completed

https://gerrit.wikimedia.org/r/308898

awight closed subtask T144562: PayPal's payments-init messages are inaccurate as Resolved.Sep 7 2016, 9:47 PM

Change 308788 merged by jenkins-bot:
Don't store payments record if the transaction is finalized

https://gerrit.wikimedia.org/r/308788

awight moved this task from Review to Pending Deployment on the Fundraising Sprint Qwerty Thwacking board.Sep 7 2016, 11:32 PM

awight renamed this task from Delete from the pending database when a transaction is failed to Delete from the pending database when a transaction is failed or completed.Sep 8 2016, 11:19 PM

awight moved this task from Pending Deployment to Done on the Fundraising Sprint Qwerty Thwacking board.