Page MenuHomePhabricator
Create Task
Maniphest T143966

integration-zuul-layoutdiff claims difference when there is none
Closed, ResolvedPublic
Actions

Description

The integration-zuul-layoutdiff job no longer properly detects the presence (or absence) of a difference by the current commit.

This is because the output now contains some kind of memory pointer or other temporary identifier that is different each time.
For example, https://gerrit.wikimedia.org/r/#/c/305993/ modifies jjb/misc.yaml only but:

jenkins-bot:

integration-zuul-layoutdiff SUCCESS Review the Zuul layout difference.

https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/10625/console:

colordiff '--show-function-line=^Pipeline: ' -u log/before.txt log/current.txt
--- log/before.txt	2016-08-26 01:38:00.998534650 +0000
+++ log/current.txt	2016-08-26 01:38:00.898533526 +0000
@@ -1,5 +1,5 @@
 Pipeline: check
-INFO:zuul.IndependentPipelineManager:  Source: <zuul.source.gerrit.GerritSource object at 0x4a04110>
+INFO:zuul.IndependentPipelineManager:  Source: <zuul.source.gerrit.GerritSource object at 0x357e110>
 INFO:zuul.IndependentPipelineManager:  Requirements:
 INFO:zuul.IndependentPipelineManager:  Events:
 INFO:zuul.IndependentPipelineManager:    <EventFilter types: patchset-created ignore_deletes: True emails: (?x) ^(?!(
@@ -4478,15 +4478,15 @@ Pipeline: check
 INFO:zuul.IndependentPipelineManager:  On start:
 INFO:zuul.IndependentPipelineManager:    []
 INFO:zuul.IndependentPipelineManager:  On success:
-INFO:zuul.IndependentPipelineManager:    [<zuul.reporter.gerrit.GerritReporter object at 0x4a04210>]
+INFO:zuul.IndependentPipelineManager:    [<zuul.reporter.gerrit.GerritReporter object at 0x357e210>]
 INFO:zuul.IndependentPipelineManager:  On failure:
-INFO:zuul.IndependentPipelineManager:    [<zuul.reporter.gerrit.GerritReporter object at 0x4a04250>]
+INFO:zuul.IndependentPipelineManager:    [<zuul.reporter.gerrit.GerritReporter object at 0x357e250>]
 INFO:zuul.IndependentPipelineManager:  On merge-failure:
-INFO:zuul.IndependentPipelineManager:    [<zuul.reporter.gerrit.GerritReporter object at 0x4a04250>]
+INFO:zuul.IndependentPipelineManager:    [<zuul.reporter.gerrit.GerritReporter object at 0x357e250>]
 INFO:zuul.IndependentPipelineManager:  When disabled:
 INFO:zuul.IndependentPipelineManager:    []
 Pipeline: check-only
-INFO:zuul.IndependentPipelineManager:  Source: <zuul.source.gerrit.GerritSource object at 0x4a04290>
+INFO:zuul.IndependentPipelineManager:  Source: <zuul.source.gerrit.GerritSource object at 0x357e290>
 INFO:zuul.IndependentPipelineManager:  Requirements:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Couple patches pending upstream mergeintegration/zuuldebian/precise-wikimedia+342 -0
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Aug 26 2016, 1:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2016, 1:59 AM
Krinkle added a subscriber: hashar.Aug 26 2016, 1:59 AM
hashar added a project: Zuul.Aug 26 2016, 8:54 AM

Indeed and that is an issue in Zuul. The objects are used to format the string but lack a string representation method so that fallback to python default of:

<objectname object at someaddress>

Need to patch the various objects to add __repr__().

hashar claimed this task.Aug 26 2016, 10:28 AM

First pass at https://review.openstack.org/#/c/361064/

Paladox subscribed.Aug 26 2016, 3:07 PM
hashar moved this task from Backlog to In progress on the Continuous-Integration-Config board.Aug 28 2016, 8:44 AM
hashar triaged this task as Medium priority.Aug 29 2016, 10:25 AM
gerritbot subscribed.Aug 29 2016, 10:37 AM

Change 307264 had a related patch set uploaded (by Hashar):
Couple patches pending upstream merge

https://gerrit.wikimedia.org/r/307264

gerritbot added a project: Patch-For-Review.Aug 29 2016, 10:37 AM
hashar lowered the priority of this task from Medium to Low.Aug 29 2016, 10:40 AM
hashar added a project: Upstream.

Fixed by cherry picking PS2 of https://review.openstack.org/#/c/361064/2 to our branch patch-queue/debian/precise-wikimedia which is used to run the tests.

Will be incorporated in our .deb package version 2.5.0-8-gcbc7f62-wmf2precise1.

What is left to do is to get the change reviewed and merged upstream, then we can close this task.

hashar moved this task from In progress to Archive on the Continuous-Integration-Config board.Aug 29 2016, 10:40 AM
hashar moved this task from Backlog to Patch proposed upstream on the Upstream board.
gerritbot added a comment.Aug 29 2016, 10:46 AM

Change 307264 merged by Hashar:
Couple patches pending upstream merge

https://gerrit.wikimedia.org/r/307264

hashar mentioned this in T144088: Upgrade Zuul on gallium to 2.5.0-8-gcbc7f62-wmf2precise1.Aug 29 2016, 10:50 AM
hashar closed this task as Resolved.Sep 12 2016, 3:11 PM

That has been resolved by deploying a newer version of Zuul on gallium (2.5.0-8-gcbc7f62-wmf2precise1) via T144088.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits