Page MenuHomePhabricator

Fix bug where blacklisted titles are not removed from the feed
Closed, ResolvedPublic

Description

https://github.com/wikimedia/wikipedia-ios/pull/863

Fixing 2 bugs:

  1. Blacklist was not being updated (due to a bad comparison)
  2. Related pages was not being updated (due to not sorting)

Event Timeline

JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

We need to verify that we have tests for these 3 things:

  1. Save a page
  2. Pull to refresh
  3. Verify the new suggestion section appears for that article
  1. Open a page
  2. Leave it open for 1 minute (only 30 seconds should be required, but just to be sure)
  3. Go to the explore feed
  4. Pull to refresh
  5. Verify the new suggestion section appears for that article
  1. Black list a page using the section menu
  2. Verify the section is removed immediately

@Fjalapeno I think we could probably create a subtask to verify the future test coverage, and then tag that subtask with Technical-Debt and backlog it. The reason for that is that this card is technically done, and not blocking release, and Josh would like to close all the tasks and archive the board. Thoughts?

Per our meeting, we will leave these open and considered required to archive/complete a release, rather then make them technical debt.

We'll need to make sure we check in on them at stand-ups/planning since time will need to be allocated to finish these tests.

Mhurd moved this task from Verify Test Coverage to Doing on the iOS-app-v5.1.0-Saturn board.

Per discussion with josh I'm adding a unit test to confirm items are actually removed from blacklist.

@Mhurd please prioritize finishing this test up, as this is the only remaining 5.2.0 task.

@JMinor @Mhurd can we also verify that this has a regression test script?

Yep. Nicholas added under test case 17.