Trying to connect my Phabricator Account (Jogo.obb) to Striker (LDAP Account also Jogo.obb) via 'Settings' -> 'Phabricator' -> 'Connect Phabricator account' results in a Server Error (500) on URL https://toolsadmin.wikimedia.org/profile/settings/phabricator/attach
There is no additional Information provided on that error page, html source is just:
<h1>Server Error (500)</h1>
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Catch and log database errors while saving models | labs/striker | master | +37 -12 |
I can't find any error logs that made it to the Logstash server, but I have found some related data in Striker's local database:
+----+------------------+--------------------+----------------+ | id | ldapname | sulname | phabname | +----+------------------+--------------------+----------------+ | 22 | JogoBot | NULL | Jogo.obb | | 23 | Jogo.obb | Jogo.obb | NULL | +----+------------------+--------------------+----------------+
The attachment of the ldapname JogoBot to the phabricator name Jogo.obb doesn't match with the data displayed on @Jogo.obb's profile page which shows the ldapname Jogo.obb. It also doesn't match with my manual queries to https://phabricator.wikimedia.org/conduit/method/user.ldapquery/
The 500 error is likely an uncaught SQL error for a duplicate key insert. The labsauth_labsuser table has a UNIQUE constraint on the phabname field. The conduit lookup for ldapname Jogo.obb is returning Jogo.obb, but that value is already associated with the ldapname JogoBot.
I can fix the duplicate key problem by removing the association of phabname Jogo.obb and ldapname JoboBot in labsauth_labsuser. That won't solve the mystery of how the attachment was created originally, but it should allow the proper attachment to be created.
{{done}}
+----+------------------+--------------------+----------------+ | id | ldapname | sulname | phabname | +----+------------------+--------------------+----------------+ | 22 | JogoBot | NULL | NULL | | 23 | Jogo.obb | Jogo.obb | NULL | +----+------------------+--------------------+----------------+
That won't solve the mystery of how the attachment was created originally, but it should allow the proper attachment to be created.
I think I can clarify this mystery, both accounts are mine. It looks like I had allready connected the JogoBot account before I created the new one Jogo.obb.
The 500 error is likely an uncaught SQL error for a duplicate key insert. The labsauth_labsuser table has a UNIQUE constraint on the phabname field. The conduit lookup for ldapname Jogo.obb is returning Jogo.obb, but that value is already associated with the ldapname JogoBot.
That sounds possible, therefore it should be catched. Also it would be nice to have the possibility to remove the connection to Phabricator on a certain way.
Change 307110 had a related patch set uploaded (by BryanDavis):
Catch and log database errors while saving models
Change 307110 merged by jenkins-bot:
Catch and log database errors while saving models