Page MenuHomePhabricator

Make MobileContext modular by creating the Blacklist service
Open, LowPublic5 Story Points

Description

Blacklist is a provisional name.


MobileContext#isBlacklistedPage and #isBlacklistedPageInternal are the part of the
MobileFrontend codebase that allows wiki administrators to disable displaying the mobile view for a set of
pages and/or a category.

AC

  • The MobileContext class no longer bears responsibility for dealing with blacklisting
  • The exists a MobileFrontend.Blacklist service that is responsible for blacklisting

Proposed Plan (YMMV)

  • Find out if MediaWiki has a cleaner way of testing whether a page is in a category
  • Create the CategoryService class, which answers the following question: is this page in that category?
  • Create the MobileFrontend.Blacklist service class, which depends on the CategoryRepository class
  • Make MobileContext depend on the service class and delegate to it when dealing with blacklisting

Event Timeline

phuedx created this task.Aug 27 2016, 10:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2016, 10:38 AM
phuedx updated the task description. (Show Details)Aug 27 2016, 10:39 AM
phuedx removed phuedx as the assignee of this task.
jhobs triaged this task as Normal priority.Aug 29 2016, 5:13 PM
jhobs moved this task from To Triage to Triaged but Future on the Readers-Web-Backlog board.
ovasileva set the point value for this task to 5.Oct 19 2016, 4:29 PM
phuedx updated the task description. (Show Details)Oct 20 2016, 7:34 AM
Jdlrobson added subscribers: pmiazga, Jdlrobson.

@pmiazga can you take a look at this and see what you think? Let's chat later in the week, but I want to start thinking about improving our MobileContext and MobileFormatter code so I think it's worth spending some time here.

Separating code by responsibilities is always a good idea. I think it's ready to work on, moving to "triaged but future".

pmiazga removed pmiazga as the assignee of this task.May 29 2017, 10:14 PM
Jdlrobson lowered the priority of this task from Normal to Low.Jun 6 2017, 5:21 PM
Jdlrobson raised the priority of this task from Low to Normal.Feb 14 2018, 11:48 PM

I'm interesting in us refactoring MobileContext given the good work we've done inside MobileFormatter.

Jdlrobson lowered the priority of this task from Normal to Low.Apr 9 2019, 4:14 PM

Reflecting reality