Page MenuHomePhabricator

Date is displayed incorrectly in the Revision Slider
Open, MediumPublic

Description

In Hebrew, we write the time first, and then the date.

Currently, in the Revision Slider, the time is displayed in the end (after the date), and it looks a little strange.

In other words: It currently looks like: {{LOCALDAY}} {{LOCALMONTHNAMEGEN}} {{LOCALYEAR}} {{LOCALTIME}}

Instead, it should look like: {{LOCALTIME}}, {{LOCALDAY}} {{LOCALMONTHNAMEGEN}} {{LOCALYEAR}}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Come on, @Guycn2.

  1. I don't sure anyone except you saw this at all.
  2. And even if he did, I'm sure it's not disturb to anyone.
  3. You were asked about this in T141167, and you said it's "the most acceptable format".

Come on, @Guycn2.

  1. I don't sure anyone except you saw this at all.
  2. And even if he did, I'm sure it's not disturb to anyone.
  3. You were asked about this in T141167, and you said it's "the most acceptable format".
  1. I'm sure a lot of people noticed it. The fact I'm the only one who reported does not mean that nobody else saw it.
  2. Why are you so sure it does not disturb? It does disturb, because the date and time are displayed in a different format anywhere on the interface, and the format should be consistent.
  3. Perhaps I said it was the most acceptable format because I only looked at the date, which was the main issue of the bug.

already in my revision slider it appears like {{LOCALTIME}}, {{LOCALDAY}} {{LOCALMONTHNAMEGEN}} {{LOCALYEAR}} only what modifications has to do

@Prabhakar369: I don't understand your last comment.
Can you please either rephrase (if it's one sentence), or use proper punctuation (if it's more than one sentence)? Thanks.

Change 638469 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/RevisionSlider@master] Fixed date format which is displayed incorrectly in the Revision Slider

https://gerrit.wikimedia.org/r/638469

@nandhinibalaji311 as you don't have any progress for sevaral months, Assigning this task to myself :-)
Please feel free to comment if you have any sugesstions :)

Preview of the above patch

Screenshot from 2020-11-03 16-24-36.png (108×325 px, 11 KB)
Before
Screenshot from 2020-11-03 16-24-08.png (189×323 px, 24 KB)
After