Page MenuHomePhabricator

"Uncaught TypeError: Cannot read property 'getModel' of null" on Developer Console when the table cells are merged
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:

  1. Open VE
  2. Insert --> Table
  3. Create few rows and columns
  4. Select the whole table and click on merge

Observation:
The table cells merge properly but there is an error message on the developer console as shown in the screenshot.

pasted_file (186×1 px, 74 KB)

Event Timeline

Ryasmeen renamed this task from "Uncaught Type Error" on Developer Console when the table is merged to "Uncaught TypeError: Cannot read property 'getModel' of null" on Developer Console when the table cells are merged.Aug 31 2016, 2:24 AM
Ryasmeen updated the task description. (Show Details)

Change 307782 had a related patch set uploaded (by DLynch):
ce.TableRowNode: check we're still attached in setupMissingCell

https://gerrit.wikimedia.org/r/307782

Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.

Change 307782 merged by jenkins-bot:
ce.TableRowNode: check we're still attached before setupMissingCell

https://gerrit.wikimedia.org/r/307782

Just wanted to add that I was not able to verify the fix yet

Jdforrester-WMF subscribed.

Just wanted to add that I was not able to verify the fix yet

Yeah, sorry, I thought this had been pulled through but it hadn't. It will be deployed next week.

Thank You so much James. Just verified the fix in beta.