Page MenuHomePhabricator
Create Task
Maniphest T144522

[EPIC] Hovercards technical debt and quality enhancements
Closed, ResolvedPublic
Actions

Description

A place for hovercards tech debt with the goal of:

  1. being ready to move hovercards into stable
  2. clean up code for hovercards so it's easier to work with

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT144522 [EPIC] Hovercards technical debt and quality enhancements
 DuplicateNoneT147306 Limit the number of globals in the Popups JS codebase
 ResolvedJhernandezT146434 SchemaPopupsSamplingRate config variable is badly named
 ResolvedphuedxT146430 Popups render method should be dumb
 ResolvedJdlrobsonT149576 Popups rendering engine should not need to generate link interaction tokens
 ResolvedJdlrobsonT146133 getEnabledState called twice on initialization
 ResolvedJdlrobsonT146132 Storage key string used some times in variable, sometimes as a literal
 Resolved• NirzarT137775 Popups should not use moment.js for a single line
 Resolved• jhobsT137527 [5hrs] Add corpus of test pages
 ResolvedJdlrobsonT125451 Popups should break without TextExtracts and PageImages installed
 ResolvedphuedxT133956 Use ResourceLoaderImageModule in the Popups extension for settings icon (not mwe-popups-settings)
 ResolvedJdlrobsonT67103 [EPIC] Hovercards: Test Coverage
 ResolvedNoneT133017 Spike: What's tested and what needs testing in Hovercards
 ResolvedJdlrobsonT133018 Set up browser tests running on CI (jenkins) for Hovercards
 ResolvedJdlrobsonT133019 Create browser tests for hovering link and showing hovercard
 ResolvedJdlrobsonT133020 Unit test ext.popups.core.js
 ResolvedNoneT133022 Unit test src/renderer.js
 DuplicateNoneT133162 Unit test ext.popups.renderer.article.js (part 2 HARD)
 InvalidNoneT133023 Unit test ext.popups.disablenavpop.js
 ResolvedJhernandezT133024 Unit test ext.popups.logger.js
 InvalidNoneT133055 Split ext.popups.settings.js in units
 ResolvedphuedxT133025 Unit test ext.popups.settings.js
 ResolvedphuedxT133054 Create browser test for add footer link in ext.popups.settings.js
 ResolvedJdlrobsonT133163 BetaFeatures test failure
 DuplicateNoneT148945 Cannot read property 'off' of null
 ResolvedJdlrobsonT160061 Minify assets via build step using node tooling
 ResolvedJdlrobsonT160406 Migrate processLinks.test.js to node-qunit

Event Timeline

ovasileva created this task.Sep 1 2016, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2016, 7:21 PM
MBinder_WMF triaged this task as Medium priority.Sep 1 2016, 8:56 PM
MBinder_WMF moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
ovasileva renamed this task from [SPIKE] Identify software quality enhancements for hovercards to Hovercards technical debt and quality enhancements.Oct 21 2016, 9:14 AM
ovasileva raised the priority of this task from Medium to High.
ovasileva added a project: Epic.
ovasileva updated the task description. (Show Details)
ovasileva moved this task from Triaged but Future to Epics/Goals on the Readers-Web-Backlog board.
ovasileva renamed this task from Hovercards technical debt and quality enhancements to [EPIC] Hovercards technical debt and quality enhancements.Oct 21 2016, 9:19 AM
ovasileva changed the status of subtask T148945: Cannot read property 'off' of null from Open to Stalled.Nov 2 2016, 8:06 PM
Jdlrobson moved this task from Epics/Goals to Upcoming on the Readers-Web-Backlog board.Apr 13 2017, 3:11 PM
Jdlrobson added a subscriber: Jdlrobson.

This goal card can be closed in the next sprint if we do the 2 remaining subtasks which are already planned for sprint +1. What do you say @ovasileva ?

Jdlrobson closed this task as Resolved.Jun 5 2017, 11:25 PM
Jdlrobson claimed this task.
Jdlrobson removed a subtask: T148850: Sampling sanity check for Schema:Popups pageview events.

I'm calling this. The scope of this task as I recall was to rewrite Popups to make it easier for developers to work with. T148850 does not fit into this remit and all the sub tasks are closed.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL