Page MenuHomePhabricator
Create Task
Maniphest T144522

[EPIC] Hovercards technical debt and quality enhancements
Closed, ResolvedPublic
Actions

Description

A place for hovercards tech debt with the goal of:

  1. being ready to move hovercards into stable
  2. clean up code for hovercards so it's easier to work with

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT144522 [EPIC] Hovercards technical debt and quality enhancements
 DuplicateNoneT147306 Limit the number of globals in the Popups JS codebase
 ResolvedJhernandezT146434 SchemaPopupsSamplingRate config variable is badly named
 ResolvedphuedxT146430 Popups render method should be dumb
 ResolvedJdlrobsonT149576 Popups rendering engine should not need to generate link interaction tokens
 ResolvedJdlrobsonT146133 getEnabledState called twice on initialization
 ResolvedJdlrobsonT146132 Storage key string used some times in variable, sometimes as a literal
 Resolved• NirzarT137775 Popups should not use moment.js for a single line
 Resolved• jhobsT137527 [5hrs] Add corpus of test pages
 ResolvedJdlrobsonT125451 Popups should break without TextExtracts and PageImages installed
 ResolvedphuedxT133956 Use ResourceLoaderImageModule in the Popups extension for settings icon (not mwe-popups-settings)
 ResolvedJdlrobsonT67103 [EPIC] Hovercards: Test Coverage
 ResolvedNoneT133017 Spike: What's tested and what needs testing in Hovercards
 ResolvedJdlrobsonT133018 Set up browser tests running on CI (jenkins) for Hovercards
 ResolvedJdlrobsonT133019 Create browser tests for hovering link and showing hovercard
 ResolvedJdlrobsonT133020 Unit test ext.popups.core.js
 ResolvedNoneT133022 Unit test src/renderer.js
 DuplicateNoneT133162 Unit test ext.popups.renderer.article.js (part 2 HARD)
 InvalidNoneT133023 Unit test ext.popups.disablenavpop.js
 ResolvedJhernandezT133024 Unit test ext.popups.logger.js
 InvalidNoneT133055 Split ext.popups.settings.js in units
 ResolvedphuedxT133025 Unit test ext.popups.settings.js
 ResolvedphuedxT133054 Create browser test for add footer link in ext.popups.settings.js
 ResolvedJdlrobsonT133163 BetaFeatures test failure
 DuplicateNoneT148945 Cannot read property 'off' of null
 ResolvedJdlrobsonT160061 Minify assets via build step using node tooling
 ResolvedJdlrobsonT160406 Migrate processLinks.test.js to node-qunit

Event Timeline

ovasileva created this task.Sep 1 2016, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2016, 7:21 PM
MBinder_WMF triaged this task as Medium priority.Sep 1 2016, 8:56 PM
MBinder_WMF moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
ovasileva renamed this task from [SPIKE] Identify software quality enhancements for hovercards to Hovercards technical debt and quality enhancements.Oct 21 2016, 9:14 AM
ovasileva raised the priority of this task from Medium to High.
ovasileva added a project: Epic.
ovasileva updated the task description. (Show Details)
ovasileva moved this task from Triaged but Future to Epics/Goals on the Readers-Web-Backlog board.
ovasileva renamed this task from Hovercards technical debt and quality enhancements to [EPIC] Hovercards technical debt and quality enhancements.Oct 21 2016, 9:19 AM
ovasileva added subtasks: T147306: Limit the number of globals in the Popups JS codebase, T146434: SchemaPopupsSamplingRate config variable is badly named, T146430: Popups render method should be dumb, T146133: getEnabledState called twice on initialization, T146132: Storage key string used some times in variable, sometimes as a literal, T137775: Popups should not use moment.js for a single line, T137527: [5hrs] Add corpus of test pages, T125451: Popups should break without TextExtracts and PageImages installed, T133022: Unit test src/renderer.js, T133055: Split ext.popups.settings.js in units, T133162: Unit test ext.popups.renderer.article.js (part 2 HARD), T133956: Use ResourceLoaderImageModule in the Popups extension for settings icon (not mwe-popups-settings), T133023: Unit test ext.popups.disablenavpop.js, T67103: [EPIC] Hovercards: Test Coverage.Oct 21 2016, 9:23 AM
bmansurov added a subtask: T148945: Cannot read property 'off' of null.Oct 26 2016, 8:16 PM
• Tbayer added a subscriber: • Tbayer.Nov 1 2016, 1:01 AM
ovasileva changed the status of subtask T146132: Storage key string used some times in variable, sometimes as a literal from Open to Stalled.Nov 2 2016, 8:03 PM
ovasileva changed the status of subtask T148945: Cannot read property 'off' of null from Open to Stalled.Nov 2 2016, 8:06 PM
• jhobs changed the status of subtask T146434: SchemaPopupsSamplingRate config variable is badly named from Open to Stalled.Dec 7 2016, 6:29 PM
• jhobs closed subtask T137527: [5hrs] Add corpus of test pages as Resolved.Dec 15 2016, 6:28 PM
ovasileva moved this task from 2016-17-Q2-Goal to Next Up on the Page-Previews board.Dec 19 2016, 7:15 PM
ovasileva edited projects, added Page-Previews; removed Page-Previews (2016-17-Q2-Goal).
ovasileva changed the status of subtask T147306: Limit the number of globals in the Popups JS codebase from Open to Stalled.Dec 19 2016, 8:06 PM
phuedx closed subtask T146430: Popups render method should be dumb as Resolved.Dec 20 2016, 10:17 AM
Jhernandez closed subtask T146434: SchemaPopupsSamplingRate config variable is badly named as Resolved.Jan 15 2017, 11:44 PM
ovasileva closed subtask T137775: Popups should not use moment.js for a single line as Resolved.Feb 3 2017, 1:42 PM
Jdlrobson closed subtask T125451: Popups should break without TextExtracts and PageImages installed as Resolved.Feb 14 2017, 9:38 PM
Jdlrobson closed subtask T146133: getEnabledState called twice on initialization as Resolved.Feb 14 2017, 9:41 PM
Jdlrobson closed subtask T146132: Storage key string used some times in variable, sometimes as a literal as Resolved.
phuedx closed subtask T133023: Unit test ext.popups.disablenavpop.js as Invalid.Feb 15 2017, 6:16 AM
phuedx closed subtask T133055: Split ext.popups.settings.js in units as Invalid.Feb 15 2017, 6:20 AM
Jdlrobson closed subtask T67103: [EPIC] Hovercards: Test Coverage as Resolved.Feb 16 2017, 6:49 PM
Jdlrobson moved this task from Epics/Goals to Upcoming on the Readers-Web-Backlog board.Apr 13 2017, 3:11 PM
Jdlrobson added a subscriber: Jdlrobson.

This goal card can be closed in the next sprint if we do the 2 remaining subtasks which are already planned for sprint +1. What do you say @ovasileva ?

Jdlrobson added a subtask: T160061: Minify assets via build step using node tooling.Apr 19 2017, 12:32 AM
Jdlrobson added a subtask: T160406: Migrate processLinks.test.js to node-qunit.Apr 19 2017, 12:35 AM
Jdlrobson added a subtask: T148850: Sampling sanity check for Schema:Popups pageview events.
Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Readers-Web-Backlog board.Apr 19 2017, 6:39 PM
phuedx closed subtask T133956: Use ResourceLoaderImageModule in the Popups extension for settings icon (not mwe-popups-settings) as Resolved.Apr 26 2017, 9:56 AM
Jdlrobson closed subtask T160406: Migrate processLinks.test.js to node-qunit as Resolved.May 1 2017, 4:55 PM
Jdlrobson closed subtask T133022: Unit test src/renderer.js as Resolved.May 10 2017, 12:39 PM
Jdlrobson closed subtask T160061: Minify assets via build step using node tooling as Resolved.May 16 2017, 9:44 AM
Jdlrobson changed the status of subtask T148850: Sampling sanity check for Schema:Popups pageview events from Stalled to Open.May 21 2017, 11:22 AM
Jdlrobson moved this task from 2016-17 Q4 to Epics/Goals on the Readers-Web-Backlog board.
Jdlrobson closed this task as Resolved.Jun 5 2017, 11:25 PM
Jdlrobson claimed this task.
Jdlrobson removed a subtask: T148850: Sampling sanity check for Schema:Popups pageview events.

I'm calling this. The scope of this task as I recall was to rewrite Popups to make it easier for developers to work with. T148850 does not fit into this remit and all the sub tasks are closed.

MBinder_WMF moved this task from Epics/Goals to 2016-17 Q4 on the Readers-Web-Backlog board.Mar 6 2018, 7:07 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL