Page MenuHomePhabricator
Create Task
Maniphest T144561

VE: can't edit <maplink>
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Esanders
Authored By
• JGirault
Sep 1 2016, 10:52 PM
Tags
Referenced Files
F4424613: Screen Shot 2016-09-02 at 12.51.38 AM.png
Sep 1 2016, 10:52 PM
F4424611: Screen Shot 2016-09-02 at 12.50.45 AM.png
Sep 1 2016, 10:52 PM
Subscribers
Aklapper
Esanders
gerritbot
• JGirault
Nux

Description

Regression of T144003, a user can't edit <maplink> with VisualEditor. The link is recognized as a regular link.

See screenshot:

Screen Shot 2016-09-02 at 12.50.45 AM.png (310×812 px, 34 KB)

Screen Shot 2016-09-02 at 12.51.38 AM.png (442×812 px, 56 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Search all RDFa attributes when looking for typemediawiki/extensions/VisualEditorwmf/1.28.0-wmf.18+2 -2
Search all RDFa attributes when looking for typemediawiki/extensions/VisualEditorwmf/1.28.0-wmf.17+2 -2
Search all RDFa attributes when looking for typemediawiki/extensions/VisualEditormaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• JGirault created this task.Sep 1 2016, 10:52 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptSep 1 2016, 10:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• JGirault added a project: VisualEditor.Sep 1 2016, 10:52 PM
MaxSem added a parent task: T144062: Epic: Enable <maplink> on Wikipedias.Sep 1 2016, 10:52 PM
MaxSem mentioned this in T144062: Epic: Enable <maplink> on Wikipedias.Sep 1 2016, 11:10 PM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Sep 2 2016, 5:16 PM
gerritbot subscribed.Sep 2 2016, 11:43 PM

Change 308300 had a related patch set uploaded (by Esanders):
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308300

gerritbot added a project: Patch-For-Review.Sep 2 2016, 11:43 PM
Esanders subscribed.Sep 2 2016, 11:51 PM

Since an href was added to the link (for non JS support) it started matching as an MW external link, due to a bug in our matching logic (only looking at 'rel' for the special type, instead of 'typeof' and 'property' as well).

• JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Sep 5 2016, 5:07 PM
• JGirault assigned this task to Esanders.Sep 5 2016, 7:18 PM
Nux subscribed.Sep 6 2016, 3:57 PM
gerritbot added a comment.Sep 6 2016, 4:42 PM

Change 308300 merged by jenkins-bot:
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308300

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 6 2016, 5:00 PM
gerritbot added a comment.Sep 6 2016, 6:49 PM

Change 308797 had a related patch set uploaded (by Yurik):
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308797

gerritbot added a comment.Sep 6 2016, 9:31 PM

Change 308797 merged by jenkins-bot:
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308797

gerritbot added a comment.Sep 6 2016, 9:35 PM

Change 308880 had a related patch set uploaded (by MaxSem):
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308880

gerritbot added a comment.Sep 6 2016, 9:43 PM

Change 308880 merged by jenkins-bot:
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308880

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)).Sep 6 2016, 10:00 PM
Jdforrester-WMF closed this task as Resolved.Sep 7 2016, 9:07 PM
Jdforrester-WMF set the point value for this task to 1.Sep 9 2016, 6:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits