Page MenuHomePhabricator

VE: can't edit <maplink>
Closed, ResolvedPublic1 Estimated Story Points

Description

Regression of T144003, a user can't edit <maplink> with VisualEditor. The link is recognized as a regular link.

See screenshot:

Screen Shot 2016-09-02 at 12.50.45 AM.png (310×812 px, 34 KB)

Screen Shot 2016-09-02 at 12.51.38 AM.png (442×812 px, 56 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 308300 had a related patch set uploaded (by Esanders):
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308300

Since an href was added to the link (for non JS support) it started matching as an MW external link, due to a bug in our matching logic (only looking at 'rel' for the special type, instead of 'typeof' and 'property' as well).

Change 308300 merged by jenkins-bot:
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308300

Change 308797 had a related patch set uploaded (by Yurik):
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308797

Change 308797 merged by jenkins-bot:
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308797

Change 308880 had a related patch set uploaded (by MaxSem):
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308880

Change 308880 merged by jenkins-bot:
Search all RDFa attributes when looking for type

https://gerrit.wikimedia.org/r/308880