Maniphest T144562

PayPal's payments-init messages are inaccurate
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Our legacy PayPal integration is sending a 'Complete' payments-init message when it redirects the user to paypal. It should be pending at that point, or we should wait till the user returns. PayPal's payments-init messages are also missing order ID.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/DonationInterface	master	+4 -4	Set order_id earlier for paypal legacy

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T117466 Q3 GOALS! (January-March) Keep at top of Q3 column
		Resolved		None	T108229 [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack
		Resolved		None	T133108 [Epic] Rewrite all queue clients to use a single shim library, improve library
		Resolved		awight	T133754 Upstream whatever we can to PHP-Queue
		Resolved		awight	T133190 Remove KeyValueStore from PHP-Queue
		Open		None	T134191 Write CiviCRM extension to view pending db records
		Resolved		None	T130897 [Epic] Consolidate "pending" queue usages
		Resolved		awight	T131275 [Epic] Move orphan rectifier out of payments
		Resolved		awight	T141486 Rewrite orphan rectifier to use the pending database and WmfFramework
		Resolved		Ejegg	T143945 Delete from the pending database when a transaction is failed or completed
		Resolved		awight	T144562 PayPal's payments-init messages are inaccurate

Event Timeline

Ejegg created this task.Sep 1 2016, 11:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2016, 11:02 PM

Change 308201 had a related patch set uploaded (by Ejegg):
Set order_id earlier for paypal legacy

https://gerrit.wikimedia.org/r/308201

gerritbot added a project: Patch-For-Review.Sep 2 2016, 5:24 PM

Ejegg added a project: Fundraising Sprint Qwerty Thwacking.Sep 2 2016, 5:24 PM

Ejegg set the point value for this task to 1.

Change 308201 merged by jenkins-bot:
Set order_id earlier for paypal legacy

https://gerrit.wikimedia.org/r/308201

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)).Sep 2 2016, 7:00 PM

awight added a parent task: T143945: Delete from the pending database when a transaction is failed or completed.Sep 6 2016, 8:22 PM

awight moved this task from Backlog to Pending Deployment on the Fundraising Sprint Qwerty Thwacking board.

• DStrine moved this task from Triage to Current Sprint & Completed in Q1 1617 on the Fundraising-Backlog board.Sep 6 2016, 9:40 PM

Hooray, this is fixed as of ct_id 37601945

• DStrine added a project: Unplanned-Sprint-Work.Sep 21 2016, 8:37 PM

mmodell removed a subscriber: awight.Jun 22 2017, 9:44 PM