Page MenuHomePhabricator

Don't allow a FlowMention for anonymous users in UI
Closed, ResolvedPublic

Description

Currently, an IP address can be entered as a valid user (i.e. @1.0.0.127). However, this does not send any mention, since mentions to anonymous users are not supported.
The pre-verification mechanism should therefore disallow clicking the "insert" button, when an IP has been entered.

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 2 2016, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 308229 had a related patch set uploaded (by Mattflaschen):
Flow mentions: Don't allow invalid users (IPs are invalid)

https://gerrit.wikimedia.org/r/308229

Change 308229 merged by jenkins-bot:
Flow mentions: Don't allow invalid users (IPs are invalid)

https://gerrit.wikimedia.org/r/308229

Addshore awarded a token.

Checked in betalabs - FlowMention of anon users is not allowed ('Insert' button stays grey).

Note:

  • usernames must have letters and cannot have dots
  • 'Insert' is inactive for any non-existent users
  • Using 'FlowMention' template on wikitext pages triggers mention-success/failure or just mention notificaitons

So I think this task can be closed.

usernames must have letters and cannot have dots

A separate task should be created for this as usernames with dots are valid.

To clarify my comment

usernames must have letters and cannot have dots

I was just checking the possibility that some users may have usernames constructed as IP addresses (or close enough), so their usernames might be viewed as anonymous names. This is not the case. A user name cannot have only numbers in it. But it's perfectly alright to have numbers/letter/words interspersed with dots.
So, username restrictions are flexible to allow all variety of username constructs, but preventive enough to not allow IP-like looking usernames.

No need for a new task then! :)

jmatazzoni closed this task as Resolved.Oct 5 2016, 6:40 PM