Page MenuHomePhabricator
Create Task
Maniphest T144648

[Regression wmf.18] VE crashes with error "Converting circular structure to JSON" while trying to add a parameter to a template
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to Insert>Template
  2. Type a template for example: Citation needed

3.Click on Add template

  1. Click on "Add more information"

5.Try to add a parameter to it by clicking on one of the them from the lists for example: Reason for citation

Observed Result:
It does not get added, there is an error in the console:
"Uncaught TypeError: Converting circular structure to JSON"

  1. Click on Insert
  2. Now Click on Edit again on the context menu of the template you just added

VE crashes with error " Uncaught TypeError: Cannot read property 'getIndex' of null"

Screen Shot 2016-09-02 at 4.15.04 PM.png (666×1 px, 210 KB)

Screen Shot 2016-09-02 at 4.10.26 PM.png (709×1 px, 190 KB)

Event Timeline

Ryasmeen created this task.Sep 2 2016, 11:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2016, 11:19 PM
Ryasmeen renamed this task from [Regression pre-wmf.18] VE crashes with error "Converting circular structure to JSON" while trying to add a parameter to it to [Regression pre-wmf.18] VE crashes with error "Converting circular structure to JSON" while trying to add a parameter to a template.Sep 2 2016, 11:19 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Sep 6 2016, 7:17 PM
Jdforrester-WMF closed this task as Resolved.Sep 7 2016, 10:25 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor-MediaWiki-Templates, MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)), MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).
Jdforrester-WMF set the point value for this task to 1.

This was fixed by https://gerrit.wikimedia.org/r/#/c/308920/ I believe, which is being back-ported in 30 minutes' time.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptSep 7 2016, 10:25 PM
Ryasmeen renamed this task from [Regression pre-wmf.18] VE crashes with error "Converting circular structure to JSON" while trying to add a parameter to a template to [Regression wmf.18] VE crashes with error "Converting circular structure to JSON" while trying to add a parameter to a template.Sep 7 2016, 10:43 PM
Ryasmeen added a project: Verified.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits