Page MenuHomePhabricator
Create Task
Maniphest T144658

Feature request: Have MediaWikiChat display a "-" rather than a "+" in the tab/window title when users leave the chat
Open, LowPublic
Actions

Description

This isn't a bug as far as I know, but the "+" added to the tab/window title of the chat when someone joins or leaves doesn't really differentiate between the two. I suggest that a "-" should be used for leaving users rather than a "+", as this would make it easier to determine whether or not someone has joined or left without having to turn on desktop notifications.

Details

SubjectRepoBranchLines +/-
Display a "-" rather than a "+" in the tab/window title when users leave the chatmediawiki/extensions/MediaWikiChatmaster+1 -1
Customize query in gerrit

Event Timeline

lcf119 renamed this task from MediaWikiChat displays a "+" in the tab/window title when users leave the chat to Feature request: Have MediaWikiChat displays a "-" rather than a "+" in the tab/window title when users leave the chat.Sep 3 2016, 4:22 AM
lcf119 renamed this task from Feature request: Have MediaWikiChat displays a "-" rather than a "+" in the tab/window title when users leave the chat to Feature request: Have MediaWikiChat display a "-" rather than a "+" in the tab/window title when users leave the chat.
lcf119 created this task.
SamanthaNguyen added a project: MediaWikiChat.Sep 3 2016, 4:31 AM
SamanthaNguyen moved this task from Backlog to Feedback / Suggestions on the MediaWikiChat board.
SamanthaNguyen subscribed.Sep 3 2016, 4:47 AM

https://github.com/wikimedia/mediawiki-extensions-MediaWikiChat/blob/master/MediaWikiChat.js#L648

gerritbot subscribed.Sep 10 2016, 9:03 PM

Change 309773 had a related patch set uploaded (by Jack Phoenix):
Display a "-" rather than a " " in the tab/window title when users leave the chat

https://gerrit.wikimedia.org/r/309773

gerritbot added a project: Patch-For-Review.Sep 10 2016, 9:03 PM
gerritbot added a comment.Sep 10 2016, 9:05 PM

Change 309773 merged by jenkins-bot:
Display a "-" rather than a " " in the tab/window title when users leave the chat

https://gerrit.wikimedia.org/r/309773

SamanthaNguyen closed this task as Resolved.Sep 10 2016, 9:15 PM
SamanthaNguyen claimed this task.

Commit merged to MediaWikiChat repo by jenkins-bot

SamanthaNguyen reassigned this task from SamanthaNguyen to ashley.Sep 10 2016, 9:15 PM
SamanthaNguyen moved this task from Feedback / Suggestions to Feature Request on the MediaWikiChat board.Sep 18 2016, 7:21 PM
SamanthaNguyen removed a project: Patch-For-Review.Jan 7 2017, 10:15 PM
lcf119 reopened this task as Open.Jan 28 2017, 4:33 AM
lcf119 raised the priority of this task from Lowest to Low.

It seems like all that has happened is that - has replaced +, as when a user joins/leaves, - is displayed regardless.

SamanthaNguyen claimed this task.Jan 28 2017, 12:45 PM
SamanthaNguyen added a subscriber: ashley.
SamanthaNguyen removed SamanthaNguyen as the assignee of this task.Jun 19 2018, 12:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL