Page MenuHomePhabricator
Create Task
Maniphest T144707

Display correct number of notifications
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Daniel_Mietchen
Sep 5 2016, 2:27 AM
Tags
Referenced Files
F4472639: Screen Shot 2016-09-15 at 11.29.11 AM.png
Sep 15 2016, 8:09 PM
F4465173: Screen Shot 2016-09-13 at 12.23.03 PM.png
Sep 13 2016, 8:54 PM
F4433976: Screenshot 2016-09-05 17.21.38.png
Sep 5 2016, 3:27 PM
F4432484: Screenshot 2016-09-05 04.16.45.png
Sep 5 2016, 2:27 AM
Subscribers
Aklapper
Catrope
Daniel_Mietchen
Etonkovidova
gerritbot
SBisson

Description

As can be seen in the screenshot, the total number of unread notifications on Wikidata is given to me as 100, but the number for Q229883 (the item with the highest activity) is given as 386, which indicates that the 100 is probably wrong.

My suspicion is that the 386 may also be off - even by one or two orders of magnitude. The reason I am suspecting this is that a few days ago, that number stood at about 2000, and I have since not gone and looked at more than a few single relevant diffs, while notifications relating to Q229883 have kept coming in in great numbers due to a series of WIDAR edits by another user.

I took some more screenshots over the last few days in case past numbers become relevant.

Screenshot 2016-09-05 04.16.45.png (800×1 px, 387 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow for count cap display in Special:Notifications sidebarmediawiki/extensions/Echomaster+15 -25
Generalize getCappedNotificationCount and move to countermediawiki/extensions/Echomaster+20 -19
"Flatten" wiki notif number in the Special:Notifications pagemediawiki/extensions/Echomaster+4 -1
Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNTmediawiki/extensions/Echomaster+24 -10
Use echo-badge-count message for cross-wiki counts in Special:Notificationsmediawiki/extensions/Echomaster+1 -1
Customize query in gerrit

Event Timeline

Daniel_Mietchen created this task.Sep 5 2016, 2:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2016, 2:28 AM
Krenair added a project: Notifications (Echo).Sep 5 2016, 3:41 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 5 2016, 3:41 AM
Daniel_Mietchen added a comment.Sep 5 2016, 3:27 PM

Another indication that at least the numbers for Wikidata total and for Q229883 are wrong: the first hasn't changed since I posted this ticket, while the second has gone down, despite new notifications for it coming in by the second.

See fresh screenshot.

Screenshot 2016-09-05 17.21.38.png (800×1 px, 379 KB)

Catrope subscribed.Sep 9 2016, 12:51 AM

As Stephane said, this appears to be because we use capped notification counts inconsistently, and also don't use messages that understand that "100" means "99+" in these places.

Catrope added a comment.Sep 9 2016, 12:53 AM

Also note that 2000 is a magic number: it's the maximum number of notifications you can have. This may be why the number of notifications for Q229883 is going down: the old ones are being deleted as new notifications (associated with different pages) arrive.

SBisson subscribed.Sep 9 2016, 2:23 PM
gerritbot subscribed.Sep 9 2016, 8:09 PM

Change 309620 had a related patch set uploaded (by Mooeypoo):
Use echo-badge-count message for cross-wiki counts in Special:Notifications

https://gerrit.wikimedia.org/r/309620

gerritbot added a project: Patch-For-Review.Sep 9 2016, 8:09 PM
Mooeypoo claimed this task.Sep 9 2016, 8:14 PM
Mooeypoo edited projects, added Collab-Team-Q1-July-Sep-2016; removed Collaboration-Team-Triage.
Mooeypoo moved this task from Untriaged to QA Review on the Collab-Team-Q1-July-Sep-2016 board.
gerritbot added a comment.Sep 9 2016, 8:20 PM

Change 309620 merged by jenkins-bot:
Use echo-badge-count message for cross-wiki counts in Special:Notifications

https://gerrit.wikimedia.org/r/309620

gerritbot added a comment.Sep 9 2016, 8:57 PM

Change 309677 had a related patch set uploaded (by Mooeypoo):
"Flatten" wiki notif number in the Special:Notifications page

https://gerrit.wikimedia.org/r/309677

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 9 2016, 9:00 PM
gerritbot added a comment.Sep 9 2016, 10:45 PM

Change 309699 had a related patch set uploaded (by Mooeypoo):
Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT

https://gerrit.wikimedia.org/r/309699

Daniel_Mietchen added a comment.Sep 10 2016, 12:44 AM
In T144707#2621758, @Catrope wrote:

As Stephane said, this appears to be because we use capped notification counts inconsistently, and also don't use messages that understand that "100" means "99+" in these places.

Yes, making that more consistent would be useful.
Just FYI, I am currently standing at 104 - not sure what the cap is.

In T144707#2621777, @Catrope wrote:

Also note that 2000 is a magic number: it's the maximum number of notifications you can have. This may be why the number of notifications for Q229883 is going down: the old ones are being deleted as new notifications (associated with different pages) arrive.

This makes sense - thanks for bringing some light into the matter. However, the maximum I have seen was 2001, not 2000.

Catrope added a comment.Sep 10 2016, 1:17 AM
In T144707#2624959, @Daniel_Mietchen wrote:
In T144707#2621758, @Catrope wrote:

As Stephane said, this appears to be because we use capped notification counts inconsistently, and also don't use messages that understand that "100" means "99+" in these places.

Yes, making that more consistent would be useful.
Just FYI, I am currently standing at 104 - not sure what the cap is.

We found out that what was happening is that sometimes, we'd take two capped numbers (each capped at 100) and sum them, without capping that number again. So if you had 4 alerts and 230 messages, we would tell you you had 104 (4+100) notifications. https://gerrit.wikimedia.org/r/309699 (which I'm about to merge) should fix this.

In T144707#2621777, @Catrope wrote:

Also note that 2000 is a magic number: it's the maximum number of notifications you can have. This may be why the number of notifications for Q229883 is going down: the old ones are being deleted as new notifications (associated with different pages) arrive.

This makes sense - thanks for bringing some light into the matter. However, the maximum I have seen was 2001, not 2000.

It's possible that it does something like "if this is the 2001st notification, schedule a job to delete the excess ones later", in which case you'd see 2001 briefly.

gerritbot added a comment.Sep 10 2016, 1:39 AM

Change 309699 merged by jenkins-bot:
Always cap notification count based on MWEchoNotifUser::MAX_BADGE_COUNT

https://gerrit.wikimedia.org/r/309699

gerritbot added a comment.Sep 12 2016, 9:07 PM

Change 310129 had a related patch set uploaded (by Mooeypoo):
Generalize getCapptedNotificationCount and move to counter

https://gerrit.wikimedia.org/r/310129

gerritbot added a comment.Sep 12 2016, 9:51 PM

Change 309677 abandoned by Mooeypoo:
"Flatten" wiki notif number in the Special:Notifications page

Reason:
This is now being dealt with in the back-end.

https://gerrit.wikimedia.org/r/309677

gerritbot added a comment.Sep 12 2016, 11:36 PM

Change 310171 had a related patch set uploaded (by Mooeypoo):
Allow for count cap display in Special:Notifications sidebar

https://gerrit.wikimedia.org/r/310171

gerritbot added a comment.Sep 13 2016, 4:07 PM

Change 310129 merged by jenkins-bot:
Generalize getCappedNotificationCount and move to counter

https://gerrit.wikimedia.org/r/310129

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)).Sep 13 2016, 5:00 PM
gerritbot added a comment.Sep 13 2016, 5:26 PM

Change 310171 merged by jenkins-bot:
Allow for count cap display in Special:Notifications sidebar

https://gerrit.wikimedia.org/r/310171

Etonkovidova subscribed.Sep 13 2016, 8:54 PM

Checked in betalabs - '99+' is correctly displayed in the badge and on Special:Notifications page.

Screen Shot 2016-09-13 at 12.23.03 PM.png (708×1 px, 155 KB)

Etonkovidova added a comment.Sep 15 2016, 8:09 PM

(1) With '99+' implemented to be displayed as a cap in the side bar, there is no more discrepancy between what's displayed as a sum of unread notifications (in the wiki title) and the actual sum of unread notifications on wiki pages.
(2)

[...] the maximum I have seen was 2001, not 2000.

Checked locally - 2,001 is displayed.

Screen Shot 2016-09-15 at 11.29.11 AM.png (672×1 px, 97 KB)

(3)
If more messages are added to the previously displayed 2001, the oldest messages will be removed. echo_notification table will always store not more than 2001.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Sep 15 2016, 8:10 PM
• jmatazzoni closed this task as Resolved.Sep 29 2016, 11:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits